[l1k:tsm_d0 1/1] drivers/crypto/ccp/sev-dev-tsm.c:43:45: error: passing argument 1 of 'class_pm_runtime_active_try_constructor' from incompatible pointer type

[kernel test robot <lkp@intel.com>]

tree:   https://github.com/l1k/linux tsm_d0
head:   5d1328bf1d1aa1bfefc2aa97b82783e053dccfda
commit: 5d1328bf1d1aa1bfefc2aa97b82783e053dccfda [1/1] PCI/TSM: Resume device to D0 for CMA-SPDM operation
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260613/202606132048.PyOSDUgd-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260613/202606132048.PyOSDUgd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606132048.PyOSDUgd-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/crypto/ccp/sev-dev-tsm.c:10:
   drivers/crypto/ccp/sev-dev-tsm.c: In function 'sev_tio_spdm_cmd':
>> drivers/crypto/ccp/sev-dev-tsm.c:43:45: error: passing argument 1 of 'class_pm_runtime_active_try_constructor' from incompatible pointer type [-Wincompatible-pointer-types]
      43 |         PM_RUNTIME_ACQUIRE(dsm->tsm.base_tsm.pdev, pm);
         |                            ~~~~~~~~~~~~~~~~~^~~~~
         |                                             |
         |                                             struct pci_dev *
   include/linux/pm_runtime.h:631:46: note: in definition of macro 'PM_RUNTIME_ACQUIRE'
     631 |         ACQUIRE(pm_runtime_active_try, _var)(_dev)
         |                                              ^~~~
   In file included from include/linux/string.h:7,
                    from include/linux/uuid.h:11,
                    from include/linux/mod_devicetable.h:14,
                    from include/linux/pci.h:27,
                    from drivers/crypto/ccp/sev-dev-tsm.c:5:
   include/linux/cleanup.h:407:40: note: expected 'class_pm_runtime_active_t' {aka 'struct device *'} but argument is of type 'struct pci_dev *'
     407 |                      class_##_name##_t _T) \
         |                      ~~~~~~~~~~~~~~~~~~^~
   include/linux/cleanup.h:294:75: note: in definition of macro 'EXTEND_CLASS_COND'
     294 | static __always_inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \
         |                                                                           ^~~~~~~~~~
   include/linux/args.h:25:24: note: in expansion of macro 'DEFINE_GUARD_COND_4'
      25 | #define __CONCAT(a, b) a ## b
         |                        ^
   include/linux/args.h:26:27: note: in expansion of macro '__CONCAT'
      26 | #define CONCATENATE(a, b) __CONCAT(a, b)
         |                           ^~~~~~~~
   include/linux/cleanup.h:419:33: note: in expansion of macro 'CONCATENATE'
     419 | #define DEFINE_GUARD_COND(X...) CONCATENATE(DEFINE_GUARD_COND_, COUNT_ARGS(X))(X)
         |                                 ^~~~~~~~~~~
   include/linux/pm_runtime.h:619:1: note: in expansion of macro 'DEFINE_GUARD_COND'
     619 | DEFINE_GUARD_COND(pm_runtime_active, _try,
         | ^~~~~~~~~~~~~~~~~
>> drivers/crypto/ccp/sev-dev-tsm.c:44:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
      44 |         if (pm_ret = PM_RUNTIME_ACQUIRE_ERR(&pm))
         |             ^~~~~~


vim +/class_pm_runtime_active_try_constructor +43 drivers/crypto/ccp/sev-dev-tsm.c

    29	
    30	static int sev_tio_spdm_cmd(struct tio_dsm *dsm, int ret)
    31	{
    32		struct tsm_dsm_tio *dev_data = &dsm->data;
    33		struct tsm_spdm *spdm = &dev_data->spdm;
    34		int pm_ret;
    35	
    36		/* Check the main command handler response before entering the loop */
    37		if (ret == 0 && dev_data->psp_ret != SEV_RET_SUCCESS)
    38			return -EINVAL;
    39	
    40		if (ret <= 0)
    41			return ret;
    42	
  > 43		PM_RUNTIME_ACQUIRE(dsm->tsm.base_tsm.pdev, pm);
  > 44		if (pm_ret = PM_RUNTIME_ACQUIRE_ERR(&pm))
    45			return pm_ret;
    46	
    47		/* ret > 0 means "SPDM requested" */
    48		while (ret == PCI_DOE_FEATURE_CMA || ret == PCI_DOE_FEATURE_SSESSION) {
    49			ret = pci_doe(dsm->tsm.doe_mb, PCI_VENDOR_ID_PCI_SIG, ret,
    50				      spdm->req, spdm->req_len, spdm->rsp, spdm->rsp_len);
    51			if (ret < 0)
    52				break;
    53	
    54			WARN_ON_ONCE(ret == 0); /* The response should never be empty */
    55			spdm->rsp_len = ret;
    56			ret = sev_tio_continue(dev_data);
    57		}
    58	
    59		return ret;
    60	}
    61	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki