From: sashiko-bot@kernel.org
To: "Andre Heider" <a.heider@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] riscv: dts: spacemit: k1-musepi-pro: add cpu scaling
Date: Sun, 14 Jun 2026 12:32:47 +0000 [thread overview]
Message-ID: <20260614123247.928FB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260614122812.2287506-1-a.heider@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The devicetree file includes 'k1-opp.dtsi', but this file is missing from the tree.
--
commit dbb35bd6325bb2f268c9e7237e65d5c614a6f755
Author: Andre Heider <a.heider@gmail.com>
riscv: dts: spacemit: k1-musepi-pro: add cpu scaling
This commit enables CPU DVFS for the SpacemiT MusePi Pro board by including
an OPP table and wiring the CPU nodes to the buck1_0v9 regulator supply.
> diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> index 0d809e4ad3b1f..1b425011f1231 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> @@ -9,6 +9,7 @@
>
> #include "k1.dtsi"
> #include "k1-pinctrl.dtsi"
> +#include "k1-opp.dtsi"
[Severity: Low]
Is the k1-opp.dtsi file missing from this series?
It appears this include will cause a devicetree compilation failure because
the file does not exist in the tree.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260614122812.2287506-1-a.heider@gmail.com?part=1
next prev parent reply other threads:[~2026-06-14 12:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 9:51 [PATCH v3 0/2] cpufreq: spacemit: Add cpufreq support for K1 SoC Shuwei Wu
2026-06-12 9:51 ` Shuwei Wu
2026-06-12 9:51 ` [PATCH v3 1/2] cpufreq: spacemit: Add K1 cpufreq driver Shuwei Wu
2026-06-12 9:51 ` Shuwei Wu
2026-06-12 10:05 ` sashiko-bot
2026-06-15 5:24 ` Viresh Kumar
2026-06-15 5:24 ` Viresh Kumar
2026-06-15 6:12 ` Shuwei Wu
2026-06-15 6:12 ` Shuwei Wu
2026-06-15 6:34 ` Viresh Kumar
2026-06-15 6:34 ` Viresh Kumar
2026-06-15 12:11 ` Shuwei Wu
2026-06-15 12:11 ` Shuwei Wu
2026-06-12 9:51 ` [PATCH v3 2/2] riscv: dts: spacemit: Add cpu scaling for K1 SoC Shuwei Wu
2026-06-12 9:51 ` Shuwei Wu
2026-06-14 6:50 ` [PATCH] riscv: dts: spacemit: orangepi-rv2: Add cpu scaling for K1, SoC Vincent Legoll
2026-06-14 6:50 ` Vincent Legoll
2026-06-15 0:41 ` Yixun Lan
2026-06-15 0:41 ` Yixun Lan
2026-06-14 12:28 ` [PATCH] riscv: dts: spacemit: k1-musepi-pro: add cpu scaling Andre Heider
2026-06-14 12:28 ` Andre Heider
2026-06-14 12:32 ` sashiko-bot [this message]
2026-06-15 5:07 ` [PATCH v3 0/2] cpufreq: spacemit: Add cpufreq support for K1 SoC Viresh Kumar
2026-06-15 5:07 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260614123247.928FB1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=a.heider@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.