All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sang-Heon Jeon <ekffu200098@gmail.com>
To: Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: devicetree@vger.kernel.org, loongarch@lists.linux.dev,
	linux-mips@vger.kernel.org,
	Sang-Heon Jeon <ekffu200098@gmail.com>
Subject: [PATCH 0/3] of/fdt, LoongArch, MIPS: fix misleading reservation success message
Date: Mon, 15 Jun 2026 01:15:00 +0900	[thread overview]
Message-ID: <20260614161503.2219681-1-ekffu200098@gmail.com> (raw)

While reading the elfcorehdr reservation paths I noticed that
fdt_reserve_elfcorehdr(), LoongArch's arch_reserve_vmcore() and MIPS's
mips_reserve_vmcore() ignore the return value of memblock_reserve() and
print a success message even when the reservation fails.

memblock_reserve() is unlikely to fail this early in boot. However,
printing success on a failed reservation is misleading. I think it is
worth fixing, but feel free to drop it if you disagree.

The three call sites are in different trees, so I split the change into
one patch per arch/subsystem. The patches are independent and can be
applied separately.

Sang-Heon Jeon (3):
  of/fdt: fix misleading elfcorehdr reservation success message
  LoongArch: fix misleading elfcorehdr reservation success message
  MIPS: fix misleading elfcorehdr reservation success message

 arch/loongarch/kernel/setup.c | 5 ++++-
 arch/mips/kernel/setup.c      | 7 +++++--
 drivers/of/fdt.c              | 5 ++++-
 3 files changed, 13 insertions(+), 4 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-06-14 16:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-14 16:15 Sang-Heon Jeon [this message]
2026-06-14 16:15 ` [PATCH 1/3] of/fdt: fix misleading elfcorehdr reservation success message Sang-Heon Jeon
2026-06-16 13:19   ` Rob Herring
2026-06-16 18:13     ` Sang-Heon Jeon
2026-06-14 16:15 ` [PATCH 2/3] LoongArch: " Sang-Heon Jeon
2026-06-14 16:15 ` [PATCH 3/3] MIPS: " Sang-Heon Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260614161503.2219681-1-ekffu200098@gmail.com \
    --to=ekffu200098@gmail.com \
    --cc=chenhuacai@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@xen0n.name \
    --cc=linux-mips@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=saravanak@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.