From: Jakub Kicinski <kuba@kernel.org>
To: Cedric Jehasse <cedric.jehasse@gmail.com>
Cc: "Cedric Jehasse via B4 Relay"
<devnull+cedric.jehasse.luminex.be@kernel.org>,
cedric.jehasse@luminex.be, "Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Luke Howard" <lukeh@padl.com>, "Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH net-next v7 2/2] net: dsa: mv88e6xxx: add support for credit based shaper
Date: Mon, 15 Jun 2026 09:54:01 -0700 [thread overview]
Message-ID: <20260615095401.4be9706c@kernel.org> (raw)
In-Reply-To: <4dvydmir7hw4zhfrxonjuu4l7as6hma5yg4iuv3vgoqed7zai6@knkmyvh4sa54>
On Mon, 15 Jun 2026 16:29:34 +0200 Cedric Jehasse wrote:
> > > +static int mv88e6xxx_setup_tc_cbs(struct dsa_switch *ds, int port,
> > > + struct tc_cbs_qopt_offload *cbs)
> >
> > please stick an extack into struct tc_cbs_qopt_offload and use it to
> > report the reason for rejection back to the user
>
> Do you mean modifying cbs_enable_offload to report a driver specified reason isof
> reportig the generic "Specified device failed to setup cbs hardware offload"?
> What should be done for other drivers who handle TC_SETUP_QDISC_CBS, but don't
> fill in extack? Should cbs_enable_offload fill in extack with "Specified device
> failed to setup cbs hardware offload"?
There's a "weak" version of the extack-setting macro which you can use
to avoid overriding the driver-specified message. With that you should
be able to set the generic error for existing switches while allowing
your driver to provide more specific reason.
BTW please note that net-next is now closed for the duration of the
merge window.
prev parent reply other threads:[~2026-06-15 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 12:10 [PATCH net-next v7 0/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-06-09 12:10 ` Cedric Jehasse
2026-06-09 12:10 ` [PATCH net-next v7 1/2] net: dsa: mv88e6xxx: use the hw tx queues Cedric Jehasse via B4 Relay
2026-06-09 12:10 ` Cedric Jehasse
2026-06-09 12:10 ` [PATCH net-next v7 2/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-06-09 12:10 ` Cedric Jehasse
2026-06-12 22:36 ` Jakub Kicinski
2026-06-13 3:37 ` Luke Howard
2026-06-15 16:51 ` Jakub Kicinski
2026-06-15 14:29 ` Cedric Jehasse
2026-06-15 16:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615095401.4be9706c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cedric.jehasse@gmail.com \
--cc=cedric.jehasse@luminex.be \
--cc=davem@davemloft.net \
--cc=devnull+cedric.jehasse.luminex.be@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukeh@padl.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.