Re: [PATCH 2/7] riscv: dts: eswin: add clock generator for EIC7700 SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The fixed-clock node name 'oscillator' triggers a deprecated fallback in the fixed-clock schema.
--

commit cde88bbabc7fa6624be08081caf3200c1a962c33
Author: Pritesh Patel <pritesh.patel@einfochips.com>

riscv: dts: eswin: add clock generator for EIC7700 SoC

This commit adds a clock generator node for the EIC7700 SoC. It also adds a
fixed-clock node representing the 24MHz crystal oscillator on HiFive Premier
P550 boards.

> diff --git a/arch/riscv/boot/dts/eswin/eic7700.dtsi b/arch/riscv/boot/dts/eswin/eic7700.dtsi
> index 430a210f01e66..a7ebb11159580 100644
> --- a/arch/riscv/boot/dts/eswin/eic7700.dtsi
> +++ b/arch/riscv/boot/dts/eswin/eic7700.dtsi

[ ... ]

> @@ -203,6 +204,11 @@ pmu {
>  				<0x00000000 0x0000000f 0xfffffffc 0x000000ff 0x00000078>;
>  	};
>  
> +	xtal: oscillator {

[Severity: Low]
Does this node name trigger a deprecation warning during dtbs_check?

The fixed-clock device tree binding schema dictates that the preferred node
name should match the pattern ^clock-([0-9]+|[a-z0-9-]+)$. Naming the node
oscillator falls into the deprecated fallback branch. 

Should this be named something like clock-xtal or clock-24m instead to avoid
warnings?

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
>  	};
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260615122016.1110206-1-pinkesh.vaghela@einfochips.com?part=2