From: Jason Gunthorpe <jgg@ziepe.ca>
To: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
Cc: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>,
Robin Murphy <robin.murphy@arm.com>,
joro@8bytes.org, will@kernel.org, m.szyprowski@samsung.com,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
dikshita.agarwal@oss.qualcomm.com
Subject: Re: [PATCH] dma-iommu: Introduce API to reserve IOVA regions for dynamically created devices
Date: Mon, 15 Jun 2026 09:52:57 -0300 [thread overview]
Message-ID: <20260615125257.GS1066031@ziepe.ca> (raw)
In-Reply-To: <da77c21d-25b3-46c3-a48f-71f0549e9f5f@oss.qualcomm.com>
On Mon, Jun 15, 2026 at 12:26:25PM +0530, Vikash Garodia wrote:
> To handle such case, we create the device dynamically and associated the
> distinct IOVA range to them,via the api introduced in this patch.
> This was prototyped in recent SOC here [1]
>
> [1] https://lore.kernel.org/linux-media/20260313-kaanapali-iris-v3-1-9c0d1a67af4b@oss.qualcomm.com/
Well, I'm not enthused by this:
+static int iris_vpu_bus_dma_configure(struct device *dev)
+{
+ struct iris_context_bank *cb = dev_get_drvdata(dev);
+
+ if (!cb)
+ return -ENODEV;
+
+ return of_dma_configure_id(dev, dev->parent->of_node, true, &cb->f_id);
+}
A custom bus and then calling configure_id on the parent which would
have already called of_dma_configure on that same of_node seems very
hacky to me.
Jason
next prev parent reply other threads:[~2026-06-15 12:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 5:49 [PATCH] dma-iommu: Introduce API to reserve IOVA regions for dynamically created devices Vishnu Reddy
2026-01-19 8:00 ` Christoph Hellwig
2026-01-19 14:13 ` Robin Murphy
2026-06-10 14:27 ` Vishnu Reddy
2026-06-12 17:26 ` Jason Gunthorpe
2026-06-15 6:56 ` Vikash Garodia
2026-06-15 12:52 ` Jason Gunthorpe [this message]
2026-06-15 17:51 ` Vishnu Reddy
2026-06-17 19:40 ` Jason Gunthorpe
2026-06-18 11:57 ` Krzysztof Kozlowski
2026-06-18 15:17 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615125257.GS1066031@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=busanna.reddy@oss.qualcomm.com \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.