From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81BDD3EFFAC for ; Mon, 15 Jun 2026 13:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781528917; cv=none; b=benAsu6ihQYp+SReuRWSiaf0obyu6kClQGiEnqucBJjPGsw2TRo8FkVXdOvY28Q1eTP5wO9SY0C/NnxRQLDNYgXvWVEpjmY7oJlViTUicDloFBn+8Nyo1QZuqSwrCQC9iZqcf1rQii5DYBKzv86BRm8ws/3pstvgB3DLCnxCF/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781528917; c=relaxed/simple; bh=YmNLIjcixKslQWnVKrrr/n991cxT1iVSMrwI+pwJ4Kk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QRZi2lnbhMqfteQHlMB18qfL1aPJXD6LTJitWjTsoNk6rFZ/roOcN2UfqCY0T5jxLJoOeaNP8sTxO4Ra8QivKkYFLN83DYjGaL6GMNqWReQxsj6TTlVo/g/kry6/9nZedJ+eV3yGfi1xIKmXITCrO4PcPHl0Yp00LClROJRhHbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OLMQrsLj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OLMQrsLj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EC621F00A3E; Mon, 15 Jun 2026 13:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781528916; bh=Sd2sRE3z3LhcOaIIZd0sNUtU3cvVBqFxkoSjXGoSdBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OLMQrsLjPEKLZrOnPyG1RXqCZnFPb8Q0BKuKiV7fG35BkEiTbJ7aAARte0l4joLYG h0ivHCa5UvzUOWjHWUfBxi3FF4r3SVGCZbZ2xbS8QFPy1c+O51FsqwUJrg7fbEOmg3 oxG7+sEHT0VoHHX/dpqwt6gx+I4J5WpqdqOM5Pkv5i0ZqhvMfRBBVzlgTyH9z/ZRAZ wXNsMaYD7IQv1xKxj5+CKEU/5taeRYcDrRs17fybyWuAtAvThT+6FyRJ/rgniqejIf NQgFF/zWoMwYPtHFaS8dcGj0GI8qm/ZlY7w/kmbIRPpkdplcO/DfhRPvnrlcM4GBbL 7qAT8TmUlrNww== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH 4/6] f2fs: avoid unnecessary fscrypt_finalize_bounce_page() Date: Mon, 15 Jun 2026 21:08:20 +0800 Message-ID: <20260615130822.2576088-4-chao@kernel.org> X-Mailer: git-send-email 2.54.0.1136.gdb2ca164c4-goog In-Reply-To: <20260615130822.2576088-1-chao@kernel.org> References: <20260615130822.2576088-1-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fscrypt_finalize_bounce_page() should be called only if we use fs layer crypto, let's avoid unnecessary fscrypt_finalize_bounce_page() in error path of f2fs_write_compressed_pages(). BTW, fscrypt_finalize_bounce_page() will check mapping of bounced page before retrieving original page, so, previously it won't cause any issue w/ fscrypt_finalize_bounce_page(), but still we'd better avoid coupling w/ any logic inside fscrypt_finalize_bounce_page(). Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index caf522d667d6..aaa0813eabcd 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -1455,10 +1455,12 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc, out_destroy_crypt: page_array_free(sbi, cic->rpages, cc->cluster_size); - for (--i; i >= 0; i--) { - if (!cc->cpages[i]) - continue; - fscrypt_finalize_bounce_page(&cc->cpages[i]); + if (fio.encrypted) { + for (--i; i >= 0; i--) { + if (!cc->cpages[i]) + continue; + fscrypt_finalize_bounce_page(&cc->cpages[i]); + } } out_put_cic: kmem_cache_free(cic_entry_slab, cic); -- 2.49.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEE0ECD98DE for ; Mon, 15 Jun 2026 13:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To: Message-ID:Date:To:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ziQQKkC7JB6pq841jtBOa5IxnPkRjosL1kkfmEQ3k/o=; b=YzDgi8tshePqk+uZd6IFAhQFeU fAFOA2OvIJbuHnvg1qWj85x68BoEym3A7ehEknDhpJHussu2su94NA7IQMpFdIaOmt8Xcy7RVQSbR e3rsaz7rXFeS3SOCMQYT5MD7hoSgWgdT5n7NYUSo+3fViHO1g8p0RdiUvxW8efMBCEcc=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wZ73c-00020P-UV; Mon, 15 Jun 2026 13:08:50 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wZ73b-00020D-Vi for linux-f2fs-devel@lists.sourceforge.net; Mon, 15 Jun 2026 13:08:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Sd2sRE3z3LhcOaIIZd0sNUtU3cvVBqFxkoSjXGoSdBk=; b=e9EN4Sk/ncRjawO0oPwk7Y84zw uu52iIPcS68hYRHG/rKJ0FukNfDm23ktya2+jWfNNTvXsJiSBMw3vrZgAj62Bzlbw3oJrIU2IsICi ag6ks7Lf0Gyvm1OvNraV7W0b9Ee+WqM/6L5PCg1dgX4N8B3ild/2FBHJ15Gx6h9YgEqs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Sd2sRE3z3LhcOaIIZd0sNUtU3cvVBqFxkoSjXGoSdBk=; b=hICiQU8oIlZSV0YfcvMPIcM6mo TPireVagT7w+PF2TF58T9g24Lef4cAEMyQWdNGKaPK5gRMHOfTmNNplEkGbdXbfczy1Cr9hsE/L72 Jmi0TfJ3ENm4GB/hlFiNB/NGiz1QkqYKQJfZGsKkf9FR0AKURyAHyVU31s3+gY7dSpBU=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wZ73W-0005xJ-JG for linux-f2fs-devel@lists.sourceforge.net; Mon, 15 Jun 2026 13:08:49 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 842F3600AB for ; Mon, 15 Jun 2026 13:08:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EC621F00A3E; Mon, 15 Jun 2026 13:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781528916; bh=Sd2sRE3z3LhcOaIIZd0sNUtU3cvVBqFxkoSjXGoSdBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OLMQrsLjPEKLZrOnPyG1RXqCZnFPb8Q0BKuKiV7fG35BkEiTbJ7aAARte0l4joLYG h0ivHCa5UvzUOWjHWUfBxi3FF4r3SVGCZbZ2xbS8QFPy1c+O51FsqwUJrg7fbEOmg3 oxG7+sEHT0VoHHX/dpqwt6gx+I4J5WpqdqOM5Pkv5i0ZqhvMfRBBVzlgTyH9z/ZRAZ wXNsMaYD7IQv1xKxj5+CKEU/5taeRYcDrRs17fybyWuAtAvThT+6FyRJ/rgniqejIf NQgFF/zWoMwYPtHFaS8dcGj0GI8qm/ZlY7w/kmbIRPpkdplcO/DfhRPvnrlcM4GBbL 7qAT8TmUlrNww== To: jaegeuk@kernel.org Date: Mon, 15 Jun 2026 21:08:20 +0800 Message-ID: <20260615130822.2576088-4-chao@kernel.org> X-Mailer: git-send-email 2.54.0.1136.gdb2ca164c4-goog In-Reply-To: <20260615130822.2576088-1-chao@kernel.org> References: <20260615130822.2576088-1-chao@kernel.org> MIME-Version: 1.0 X-Headers-End: 1wZ73W-0005xJ-JG Subject: [f2fs-dev] [PATCH 4/6] f2fs: avoid unnecessary fscrypt_finalize_bounce_page() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net fscrypt_finalize_bounce_page() should be called only if we use fs layer crypto, let's avoid unnecessary fscrypt_finalize_bounce_page() in error path of f2fs_write_compressed_pages(). BTW, fscrypt_finalize_bounce_page() will check mapping of bounced page before retrieving original page, so, previously it won't cause any issue w/ fscrypt_finalize_bounce_page(), but still we'd better avoid coupling w/ any logic inside fscrypt_finalize_bounce_page(). Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index caf522d667d6..aaa0813eabcd 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -1455,10 +1455,12 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc, out_destroy_crypt: page_array_free(sbi, cic->rpages, cc->cluster_size); - for (--i; i >= 0; i--) { - if (!cc->cpages[i]) - continue; - fscrypt_finalize_bounce_page(&cc->cpages[i]); + if (fio.encrypted) { + for (--i; i >= 0; i--) { + if (!cc->cpages[i]) + continue; + fscrypt_finalize_bounce_page(&cc->cpages[i]); + } } out_put_cic: kmem_cache_free(cic_entry_slab, cic); -- 2.49.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel