From: Jakub Kicinski <kuba@kernel.org>
To: Wongi Lee <qw3rtyp0@gmail.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
asml.silence@gmail.com, dhowells@redhat.com, willemb@google.com,
Jungwoo Lee <jwlee2217@gmail.com>
Subject: Re: [PATCH net v3 2/2] ipv6: account for fraggap on the paged allocation path
Date: Mon, 15 Jun 2026 13:39:45 -0700 [thread overview]
Message-ID: <20260615133945.6e94c2d9@kernel.org> (raw)
In-Reply-To: <aiq5VQknt1QHcvio@DESKTOP-19IMU7U.localdomain>
On Thu, 11 Jun 2026 22:34:13 +0900 Wongi Lee wrote:
> copy = datalen - transhdrlen - fraggap - pagedlen;
> - /* [!] NOTE: copy may be negative if pagedlen>0
> - * because then the equation may reduces to -fraggap.
> - */
> if (copy < 0 && !(flags & MSG_SPLICE_PAGES)) {
You remove the comment because copy can never be negative with
pagedlen>0 now, can we not remove "!(flags & MSG_SPLICE_PAGES)"
as well then?
prev parent reply other threads:[~2026-06-15 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 13:26 [PATCH net v3 0/2] ipv4/ipv6: account for fraggap on paged allocation paths Wongi Lee
2026-06-11 13:32 ` [PATCH net v3 1/2] ipv4: account for fraggap on the paged allocation path Wongi Lee
2026-06-15 7:32 ` Ido Schimmel
2026-06-11 13:34 ` [PATCH net v3 2/2] ipv6: " Wongi Lee
2026-06-15 7:30 ` Ido Schimmel
2026-06-15 20:39 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615133945.6e94c2d9@kernel.org \
--to=kuba@kernel.org \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jwlee2217@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qw3rtyp0@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.