From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58AB8322C88 for ; Tue, 16 Jun 2026 01:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781573318; cv=none; b=mV+ZNd50TaTBUslYrxgqaUz77YXoWClrHErDgIK8+DBP091Q3ZBx3gTIp4V4P8tebR4tKBpeY/sCfDMzPlVFaR/OZG2byjT3n3PBswdGX1i0smXcphMWO1K3Xe6i4qTWh5SLptNCjZmOxdO73nRZxN3MMPvhuJu1Vv8iguFayn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781573318; c=relaxed/simple; bh=Jfj/qST2SynNhgunrW/TikyhLckofUnsfRusM6W2AjQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=alCkp8Re1BM6+EbsPNO6rF5o9wmY6F+h58PnCiaz1dKuno6IHTW2h8xXSyFI9rxhnWMF44huZqFaRpQHmVgMsmL21vH3NDJlXp8gjClDGhJA8D73eoXpqQr8CbyWssKYeGmcDD9gx3CZtB577YhsSuH8nFfd2tIpKr5FY9QWvAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hx/ymYIa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hx/ymYIa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6B9C1F000E9; Tue, 16 Jun 2026 01:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781573317; bh=gSyUofyLXOVTQd+RwXpSZRUGlZReLxUO8C/6tz2LHBk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Hx/ymYIahQU3R6ULVGOjS95v3SJjVRMaCmuGfQbTGZ5JV+T1+vBhc4w9NTkjTW+pb t4rjLWcRoZmEq8W1cWw0L00sKEAbDfDBsyqfkQhaa2+hTqBVMr1W0Y57gGGwVmBpc1 TcCEq2/6Cqkm3Oy6OKHppwGiHlL+AopaVSMzJqwtsFUz2a8rpdjsxNb6F1i5YH0qKM 2pQb7PqXb9voYdFh1Tc9uSBZAUIEUlgNrTfAhe0ArlSR7ZBu401opNCMGMwb8NJHMt qSUSXkG4cKDCNd5JeMYXqQyimgNVroIzfrs6wx2DR1xIYK3QnU8lmHxXAdqsSqbtrF zZ/bbHWt3uSrA== Date: Mon, 15 Jun 2026 18:28:36 -0700 From: Jakub Kicinski To: "Creeley, Brett" Cc: Breno Leitao , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, brett.creeley@amd.com, eric.joyner@amd.com Subject: Re: [PATCH net-next] eth: ionic: delete the incorrect link_down_count reporting Message-ID: <20260615182836.24b0b329@kernel.org> In-Reply-To: <3193fb6f-d786-4b8a-ace3-d63264c95529@amd.com> References: <20260615170153.592171-1-kuba@kernel.org> <3193fb6f-d786-4b8a-ace3-d63264c95529@amd.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Jun 2026 10:29:54 -0700 Creeley, Brett wrote: > >> memcpy_fromio(p + offset, idev->dev_cmd_regs->words, size); > >> } > >> > >> -static void ionic_get_link_ext_stats(struct net_device *netdev, > >> - struct ethtool_link_ext_stats *stats) > >> -{ > >> - struct ionic_lif *lif = netdev_priv(netdev); > >> - > >> - if (lif->ionic->pdev->is_physfn) > >> - stats->link_down_events = lif->link_down_count; > > It seems this is the only place where link_down_count is read. Maybe you > > want to kill it as well? > > It still shows in debugfs, but we'd be fine with it being removed > completely in favor of the correct implementation from Eric at: > https://lore.kernel.org/netdev/20260614205303.48088-5-eric.joyner@amd.com/. TBH I missed that Eric posted v5 already and assumed he won't make it before net-next is closed. Sorry for the noise... -- pw-bot: reject