From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA1663AD510; Mon, 15 Jun 2026 18:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781549544; cv=none; b=oxFxm9YaTlilgvQaQ4sHs6ZgA6Ji30xabMRZLzbAbC6fMZQVKg7HKSqCpTgUPPemK0lUjSHISLjHVs0K70kSk5QC57yVkz6I15ogfS46rQLQXvKvNbWMpNnCaPbjI4HrKGpuJUHKoi+IlAeljYN3gQ3vgaV1vUdA5nkUt8ZIysA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781549544; c=relaxed/simple; bh=AzdW+5VaWGnwO28CeMXXmLTpahwshtpVzPppI25D5Zs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=qHvg6UJ/NB9UMGCBsRBlQJ81dMOrz4rQnIQ7p3lxwfexCK9O1QPKexjU7oXzvASYv8QfsrIVLZ9GeJgXPmiZlnm1bBp8K4CVmwOkH/w7VA4dAsLNJGJgL86SIslsnn7do+vQGNoaRpoITGG8npmo5hAVEjkiQD27Gqjs85M09iA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IIcwZrXa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IIcwZrXa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B9A11F000E9; Mon, 15 Jun 2026 18:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781549543; bh=AzdW+5VaWGnwO28CeMXXmLTpahwshtpVzPppI25D5Zs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IIcwZrXa4xpN7MRcLnXp1Ulr60xNCM49S+x6XM5tgOB07xoyf4nuRHIYe4jFs5CyS 47R7j1n6oVA/Dkbf8p7rIwqke4tqhMJjEv9fTipb4LVhpWqLN52xB8xpVf8D9fz7Gm EsHPNLdVgY4YL4Ffb6ZAWAS4rcHw1GQZrs322OyNa0Iim4B33njEIRqfA17VQlB5se p2xiIodqvts0Nw0+Itn1to+gh4PKyZrncdzKgV7bcewc6oMjuhJPaFfW1ZYWrfqxXC UUsh+swzzLwZjlCyqO6iox4m/zMv5uOMZEvQpISRHulZ1m4bSIOcax2s/aLgGb3tLP E/kGOJRI1qJBg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v19 3/3] vfio/pci: Remove the pcie check for VFIO_PCI_ERR_IRQ_INDEX Reply-To: sashiko-reviews@lists.linux.dev To: "Farhan Ali" Cc: linux-s390@vger.kernel.org, "Alexander Gordeev" , "Heiko Carstens" , "Vasily Gorbik" , linux-pci@vger.kernel.org In-Reply-To: <20260615183616.2902-4-alifm@linux.ibm.com> References: <20260615183616.2902-4-alifm@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 15 Jun 2026 18:52:22 +0000 Message-Id: <20260615185223.5B9A11F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > The error signaling is configured for the vast majority of devices and it= 's > extremely rare that it fires anyway. Removing the pcie check will allow > userspace to be notified on errors for legacy PCI devices. The Internal > Shared Memory (ISM) device on s390 is one such device. For PCI devices on > IBM s390 error recovery involves platform firmware and notification to > operating system is done by architecture specific way. So the ISM device > can still be recovered when notified of an error. >=20 > Reviewed-by: Julian Ruess > Reviewed-by: Niklas Schnelle > Reviewed-by: Alex Williamson > Signed-off-by: Farhan Ali Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260615183616.2902= -1-alifm@linux.ibm.com?part=3D3