From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96EE63BBFB3; Mon, 15 Jun 2026 22:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781562814; cv=none; b=L7/u/vij3PgV7g7RexBgn/udNEh9m9qRfsSup6w1WYSHyMwyztODsCNDHdgXE1vH4CTVNmaGPHi9jFAzkkJ6qcgyIzSnNijnWHoPpLJr3Tk5jz7PpSiQVo7k/7HMQoOYNr+JB51fh5EdG7zfKvgkkZOcRTM/E7zCrCgKOL7y2H0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781562814; c=relaxed/simple; bh=NRiKmhnmjLYlJafMKqk7qKUNLZ2QLSADLHKNOka4yqg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ORfrVo5SgQKmyl0ni/px3ivKL8GUHuplPEqUH9w2HkbtqOBuTkH3VBQiKtbBrjfA1Ek9sR8cqOr2/OKVm8cTsd72fbGhxyENysqc56Q0mkKPvfYrYz6pFNxr2U8G/nrbCkVcIxSwcmEUKY3Smjv1As1AoQ7aO1IKnGaRh4XFwNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iXDRgg+t; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iXDRgg+t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AC071F00A3A; Mon, 15 Jun 2026 22:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781562813; bh=bY7pKN93MZ0mC+o+KJ5949YOMQsNMysQBTZt8566+70=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=iXDRgg+tVbucYTkJORUxGu+TzpJNFU/AbNBhbwufMTc/QwIpZ7vl+bVDxBIodlfEK dS6E39PPMYbzYZSDTm0e92+MFDeB7COKc3viz4R4J1rVi5wLxLYevHgHfB/cMvg6EQ 7FDlRVOV2UNZeFmMCh3c94VA2F++sod/FcdwQXLucU7TiEJCHol/E36cmblDP+5Zr3 UOlDViOe0llbFOGtkG+zgaUM6h3u5GfVD5EGAP6JpXE1pf5YHbhztivhJiN+k7ypnG mBq71AurSDkfnvij46owFwwnGG4Sx6LEPW1KKT51EQQ8D+rMRFSPBmrrpuX8xCLIia EnegTRbiI6ESA== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , sashiko-bot , Claude Subject: [PATCH 9/9] perf dso: Set standard errno on decompression failure Date: Mon, 15 Jun 2026 19:32:49 -0300 Message-ID: <20260615223249.36598-10-acme@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260615223249.36598-1-acme@kernel.org> References: <20260615223249.36598-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo dso__get_filename() sets errno to a negative custom DSO_LOAD_ERRNO value when kernel module decompression fails: errno = *dso__load_errno(dso); /* e.g. -9996 */ The caller __open_dso() then computes fd = -errno, producing a large positive value (9996) that looks like a valid file descriptor. This can cause close_data_fd() to close an unrelated fd used by another subsystem. Set errno to EIO instead. The detailed error code is already stored in dso__load_errno(dso) for diagnostic messages. Fixes: 1d6b3c9ba756a513 ("perf tools: Decompress kernel module when reading DSO data") Reported-by: sashiko-bot Cc: Namhyung Kim Assisted-by: Claude Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/dso.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 79f1a30f3683d6b3..2309196d8df3111c 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -600,7 +600,13 @@ static char *dso__get_filename(struct dso *dso, const char *root_dir, size_t len = sizeof(newpath); if (dso__decompress_kmodule_path(dso, name, newpath, len) < 0) { - errno = *dso__load_errno(dso); + /* + * Use a standard errno value, not the negative custom + * DSO_LOAD_ERRNO stored in dso__load_errno(dso): + * __open_dso() computes fd = -errno, so a negative + * errno produces a positive fd that looks valid. + */ + errno = EIO; goto out; } -- 2.54.0