From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEEA230D3FC for ; Mon, 15 Jun 2026 06:59:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781506746; cv=none; b=A5SpUok/YJEmGGEW0CVGNdy82qpXDqa2JdBROdSvE6cdO4sN+ZA/a11rVOYDCER/LaSez6iToPptthocwAZj3Wqtp2pvfNKIEU8YE07VCiY+nm3Fv795lp6qzy4vkh21WBOh2MJJR0iufm44FE/HCNBgCH9XilfbYahOtzAAKA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781506746; c=relaxed/simple; bh=yzoKnrHx1zt07ePMiyIAUMaKCrvByZ1Z25XkxgMqe1w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Er5WzMTUfW5EbxUeI7EzpLwqvJyIYI6fPUCGE9F2tNUSXrMX0kzeiOSykKjgTAHQJyexS9/bFEzBpCXmxqHX7wGJxk0Tn5lOwPJaz4J+PdmyqwUyiETxbIMgmg6Zs3esDoj60D/f1roHQJwBcKcpemRJZmk/RXJkjOOWH9I4zZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OaeZXNel; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OaeZXNel" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65F771F000E9; Mon, 15 Jun 2026 06:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781506745; bh=De1Jwh+6pnBCHCGtxRVs9ztzuy+BVxkf6NPp6WZ7kL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OaeZXNeleD4ofbkmnisA731/Hpt6O6f/NzOkLqXrnlOYqMG/xGvmIziq5kwz1krp/ Zke6mXfRFGkDBuYeT9K7jdM2qFQViNnOP9Z1rdCcH3W6K6Oo9AoaNc6rdqJc8pNlet vB5U6pbqQ5kxYHj4RVkHEaycXiS9yCsW9GnYytqk= Date: Mon, 15 Jun 2026 08:58:01 +0200 From: Greg Kroah-Hartman To: Pengpeng Hou Cc: Michael Hennerich , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: ad525x_dpot: fix sysfs cleanup paths Message-ID: <2026061555-overnight-cornea-cbf3@gregkh> References: <20260615065140.77960-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615065140.77960-1-pengpeng@iscas.ac.cn> On Mon, Jun 15, 2026 at 02:51:40PM +0800, Pengpeng Hou wrote: > ad_dpot_probe() creates per-RDAC sysfs files and then, for devices with > increment/decrement commands, creates the command sysfs group. Which is the incorrect way of creating sysfs files for many reasons, not the least being what you found here. Please fix this by using a default group and the is_visable() callback instead. That way it will "just work" as the driver core will handle all of this properly. Huge hint, whenever a driver calls a sysfs_*() function, it is doing something wrong. thanks, greg k-h