Re: [PATCH v5 14/16] media: iris: add Gen2 firmware support on the Agatti platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Incomplete dual firmware refactoring leads to build breakage and NULL pointer dereference during device probe.
--

commit 56abb89242d476eadcfa7c399ffc9ee1dfc1fca4
Author: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>

media: iris: add Gen2 firmware support on the Agatti platform

This patch extends the iris driver to support both HFI Gen1 and Gen2
firmwares for the Agatti platform.

> diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu_ar50lt.c b/drivers/media/platform/qcom/iris/iris_platform_vpu_ar50lt.c
> index 393256f39112b..d9de7dcb59e3a 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_vpu_ar50lt.c
> +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu_ar50lt.c

[ ... ]

> @@ -78,7 +84,8 @@ static struct platform_inst_caps platform_inst_cap_ar50lt = {
>  };
>  
>  const struct iris_platform_data qcm2290_data = {
> -	.firmware_desc_gen1 = &iris_vpu_ar50lt_p1_gen1_s6_desc,
> +	.firmware_desc_gen1 = &iris_vpu_ar50lt_p1_gen1_desc,
> +	.firmware_desc_gen2 = &iris_vpu_ar50lt_p1_gen2_s6_desc,
>  	.vpu_ops = &iris_vpu_ar50lt_ops,

[Severity: High]
Does struct iris_platform_data actually contain the firmware_desc_gen2 field?

It looks like this might cause a build failure if struct iris_platform_data
hasn't been updated to include these specific gen1/gen2 fields.

Additionally, does this introduce a NULL pointer dereference during device
probe? If iris_probe() in drivers/media/platform/qcom/iris/iris_probe.c
still unconditionally reads the legacy firmware_desc field:

iris_probe() {
    ...
    core->iris_firmware_desc = core->iris_platform_data->firmware_desc;
    core->iris_firmware_data = core->iris_firmware_desc->firmware_data;
    ...
}

Won't this dereference a NULL pointer since the legacy firmware_desc is left
uninitialized for this platform? It seems a prerequisite patch refactoring
struct iris_platform_data and the probe function might be missing from this
series.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com?part=14