Re: [PATCH net] net: dsa: Fix skb ownership in taggers

[Qingfang Deng <qingfang.deng@linux.dev>]

On 16 Jun 2026 at 00:33:00 +0200, Linus Walleij wrote:
> diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c
> index cf9420439054..23f032b76190 100644
> --- a/net/dsa/tag_brcm.c
> +++ b/net/dsa/tag_brcm.c
> @@ -102,10 +102,12 @@ static struct sk_buff *brcm_tag_xmit_ll(struct sk_buff *skb,
>  	 * (including FCS and tag) because the length verification is done after
>  	 * the Broadcom tag is stripped off the ingress packet.
>  	 *
> -	 * Let dsa_user_xmit() free the SKB
> +	 * Free the SKB on error.
>  	 */
> -	if (__skb_put_padto(skb, ETH_ZLEN + BRCM_TAG_LEN, false))
> +	if (__skb_put_padto(skb, ETH_ZLEN + BRCM_TAG_LEN, false)) {
> +		kfree_skb(skb);

There are multiple __skb_put_padto() calls in this patch, which can be
simplified to:

	if (skb_put_padto(skb, minlength))
		return NULL;

skb_put_padto() frees the skb on error.

Regards,
Qingfang