From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 888A8CD98CE for ; Tue, 16 Jun 2026 04:55:29 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id F23ED3E1FF9 for ; Tue, 16 Jun 2026 06:55:27 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 010B53E1FF9 for ; Tue, 16 Jun 2026 06:54:25 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 7120B6018BF for ; Tue, 16 Jun 2026 06:54:24 +0200 (CEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65G0msuh3992737; Tue, 16 Jun 2026 04:54:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=V+Yqbb12CI2jwjT9e 4gpwbcB8O/v7UcGi3RV8QXrc5c=; b=oaqMcSqQaXALRIlivXIu849HHcYB9CYjP kwlHtFpK2AO+NCvAmcqqirRo1mDPgm/e3bRHMK4Um8Y+bfIaAnZuFKUiDAbQyKsS 7ujCFZfE4IE5heQMWNsgaVnKwnNim5viHSEzIjvX/vh+10Z8F5pJ997xJ8BDPsg0 OPUFQV/Usr2tdt/1q8aZCKqyrOYEny4/Q8ZlNYetlUS5JYxS5VxQD/JWqY4aXpo0 SHJAEZ5y5P7XcKIbU8arJNzp0BM49CVzMlQW22O5MS5Qi2BIqh1tEHoFmJAY+SQd Gztl70AZrDAKJLSrxbrMLqycH0EJHwdwzHs4+cen0KFX209ScWH5w== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4es1u0ke8f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2026 04:54:22 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65G4naXT009402; Tue, 16 Jun 2026 04:54:21 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4esk1h1ps9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Jun 2026 04:54:21 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65G4sJZl52691354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Jun 2026 04:54:19 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AA51220043; Tue, 16 Jun 2026 04:54:19 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B3C620040; Tue, 16 Jun 2026 04:54:19 +0000 (GMT) Received: from localhost.localdomain (unknown [9.43.76.19]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 16 Jun 2026 04:54:18 +0000 (GMT) From: Sachin Sant To: ltp@lists.linux.it Date: Tue, 16 Jun 2026 10:24:09 +0530 Message-Id: <20260616045414.9081-4-sachinp@linux.ibm.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260616045414.9081-1-sachinp@linux.ibm.com> References: <20260616045414.9081-1-sachinp@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: j3KZBHSUSaABFi-0H4L81HL0Wo5_QnXM X-Authority-Analysis: v=2.4 cv=XdK5Co55 c=1 sm=1 tr=0 ts=6a30d6fe cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=4r56s12NWv49vHn13p0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDA0NSBTYWx0ZWRfX2NXd0uMGyvPL CtrFx41UY7DWMuT/dNZdJdcrMcibHpz9HQZvSMA6RRfoF9eLtds6AO2iGI2pb+OWdCWyiLIPBxc 5QQVfro/cstYREZj69aQ5Mtt0cNo+85aWbn4P85g6WT9497iUzpd1DYDQZsXhliU7KE8NWs0C+N ead7z12lDPik3u5IW8rPrx5EvQ0Fsd0mC3lKWsKZWYba96j8WVFAm+7OOinJEOj6GCXWxRrew3E fYLDuGFM2KQvZvfpUfiWP/dxOC1akLxr1FAEy6ZhhIQ1unWLlu7KvVBr4OEXXC+VvGt8HjYMI6V K9+vSxyFB0x3I1wN6eF3FLoXY9GT5uAlBip+19WwjZ87GK8CgEfqPxT2WdEfqKrMPnxEoNCL7Qn bLhzl52jZomr9JJNYlldthdBNckImLk+Bj80WWP/WaBLS6WVgAdkg44pfAf14Cniihrehv02a7U 0oEblwAZVdMy3Ea8wFA== X-Proofpoint-ORIG-GUID: j3KZBHSUSaABFi-0H4L81HL0Wo5_QnXM X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDA0NSBTYWx0ZWRfXyUv5wtlwX/NS LsYyY82BQb4aB0dUe5zzEp+s+gNB9MaUfAeit86PbfQmgZNhsLVJXDqYCgdWN95MqRrDrO8IdpK I+j9eeBP2ubNbjhL5EKfgk9X8R5431g= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_01,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160045 X-Virus-Scanned: clamav-milter 1.0.9 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v12 3/8] fs/acl: Add ACL_OTHER permission test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Add test to verify ACL_OTHER permissions work correctly and are not restricted by ACL_MASK. The test sets up an ACL with: - ACL_OTHER with rwx permissions - ACL_MASK with no permissions (---) - Verifies that a user matching ACL_OTHER can still create files This validates that ACL_OTHER permissions are applied directly without mask restriction, as specified in POSIX ACL semantics. Suggested-by: Cyril Hrubis Signed-off-by: Sachin Sant --- No changes in V7 to V12 V6 changes: - Added HAVE_SYS_XATTR_H guard - Removed redundant error checking, relying on library functions - Updated algorithm documentation with correct format - v5 link https://lore.kernel.org/ltp/20260608092200.92827-1-sachinp@linux.ibm.com/T/#t V5 changes: - Switch to kernel only test validation to remove dependency on libacl and useradd/del commands. - v3 link https://lore.kernel.org/ltp/20260604065417.25924-1-sachinp@linux.ibm.com/T/#t V4 changes: - No change V3 changes: - Updated copyright header as per LTP format. - v1 link https://lore.kernel.org/ltp/20260602121958.27494-1-sachinp@linux.ibm.com/T/#t V2 changes: - No change V1 changes: - Use HAVE_LIBACL guards in .c code - Report TCONF when libacl is not available - rfc link https://lore.kernel.org/ltp/477836fd-80c8-4168-bfe6-00b374bb2534@linux.ibm.com/T/#t --- runtest/fs | 1 + testcases/kernel/fs/acl/.gitignore | 1 + testcases/kernel/fs/acl/acl_other01.c | 104 ++++++++++++++++++++++++++ 3 files changed, 106 insertions(+) create mode 100644 testcases/kernel/fs/acl/acl_other01.c diff --git a/runtest/fs b/runtest/fs index 69ecb8647..f25487a33 100644 --- a/runtest/fs +++ b/runtest/fs @@ -91,3 +91,4 @@ squashfs01 squashfs01 # Run the acl tests acl_user_obj01 acl_user_obj01 acl_mask01 acl_mask01 +acl_other01 acl_other01 diff --git a/testcases/kernel/fs/acl/.gitignore b/testcases/kernel/fs/acl/.gitignore index bfcdee93d..c3ec0fad3 100644 --- a/testcases/kernel/fs/acl/.gitignore +++ b/testcases/kernel/fs/acl/.gitignore @@ -1,2 +1,3 @@ /acl_user_obj01 /acl_mask01 +/acl_other01 diff --git a/testcases/kernel/fs/acl/acl_other01.c b/testcases/kernel/fs/acl/acl_other01.c new file mode 100644 index 000000000..41349223e --- /dev/null +++ b/testcases/kernel/fs/acl/acl_other01.c @@ -0,0 +1,104 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (c) 2026 IBM + * + * Original shell test by Kai Zhao (ltcd3@cn.ibm.com) + * Converted to C by Sachin Sant + */ + +/*\ + * Test ACL_OTHER permissions using direct xattr manipulation. + * + * Verify that ACL_OTHER permissions work correctly and are not affected + * by ACL_MASK. The ACL_OTHER entry controls access for users who don't + * match any other ACL entry (not the owner, not in any named user entry, + * not in the owning group, and not in any named group entry). + * + * Unlike ACL_USER, ACL_GROUP, and ACL_GROUP_OBJ entries, ACL_OTHER + * permissions are not restricted by the ACL_MASK. + * + * This test uses arbitrary UIDs without creating actual users, testing + * only the kernel ACL implementation. + * + * [Algorithm] + * + * - Set up ACL with rwx permissions for ACL_OTHER + * - Set ACL_MASK to --- (no permissions) + * - Attempt file creation as a user matching ACL_OTHER + * - Verify access is granted despite restrictive mask + */ + +#include "acl_lib.h" + +#ifdef HAVE_SYS_XATTR_H + +#define TEST_UID 1000 +#define TEST_GID 1000 +#define OTHER_UID 2000 +#define OTHER_GID 2000 + +static void run(void) +{ + struct acl *acl; + + tst_res(TINFO, "Testing ACL_OTHER permissions"); + reset_test_path(); + + SAFE_CHOWN(TESTDIR, TEST_UID, TEST_GID); + + acl = acl_init(); + + acl_add_entry(acl, ACL_USER_OBJ, + ACL_READ | ACL_WRITE | ACL_EXECUTE, 0); + acl_add_entry(acl, ACL_GROUP_OBJ, 0, 0); + acl_add_entry(acl, ACL_MASK, 0, 0); + acl_add_entry(acl, ACL_OTHER, + ACL_READ | ACL_WRITE | ACL_EXECUTE, 0); + + if (acl_set_file(TESTDIR, ACL_TYPE_ACCESS, acl) < 0) { + if (errno == EOPNOTSUPP) { + acl_free(acl); + tst_brk(TCONF | TERRNO, "ACL not supported"); + } + acl_free(acl); + tst_brk(TBROK | TERRNO, "ACL setup failed"); + } + + acl_free(acl); + + try_create_as(OTHER_UID, OTHER_GID, 0644, 0); + + cleanup_testfile(); +} + +static void setup(void) +{ + reset_test_path(); +} + +static void cleanup(void) +{ + cleanup_test_paths(); +} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .cleanup = cleanup, + .needs_root = 1, + .mount_device = 1, + .mntpoint = MNTPOINT, + .forks_child = 1, + .filesystems = (struct tst_fs[]) { + {.type = "ext2", .mnt_data = "acl"}, + {.type = "ext3", .mnt_data = "acl"}, + {.type = "ext4", .mnt_data = "acl"}, + {.type = "xfs"}, + {.type = "btrfs"}, + {} + } +}; + +#else + TST_TEST_TCONF("sys/xattr.h is not available"); +#endif -- 2.39.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp