From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/366: check minimum dio size correctly
Date: Tue, 16 Jun 2026 07:28:31 +0200 [thread overview]
Message-ID: <20260616052831.GA23960@lst.de> (raw)
In-Reply-To: <ajBbo5LX-1tk-y3_@zlang-mailbox>
On Tue, Jun 16, 2026 at 04:13:22AM +0800, Zorro Lang wrote:
> Oh, if we only need to run it once, how about:
>
> blksz=""
> for (( i = 0; i < $iterations; i++)); do
> ...
> if [ -z "$blksz" ];then
> blksz=`$here/src/min_dio_alignment $SCRATCH_MNT $SCRATCH_DEV`
> if [[ $blksz -gt 512 ]]; then
> _notrun "512 byte dio alignment required"
> fi
> fi
> ...
I can look into it. But to me this doesn't really seem worth the
effort as calling min_dio_alignment is so cheap compared to the
mount/unmount cycle never mind everything else we do in the loop.
next prev parent reply other threads:[~2026-06-16 5:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 7:00 [PATCH] generic/366: check minimum dio size correctly Christoph Hellwig
2026-06-14 18:58 ` Zorro Lang
2026-06-15 13:33 ` Christoph Hellwig
2026-06-15 20:13 ` Zorro Lang
2026-06-16 5:28 ` Christoph Hellwig [this message]
2026-06-16 6:13 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616052831.GA23960@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.