Re: [PATCH v2 10/12] perf tests: Speed up off-cpu profiling tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately describes the new off-cpu threshold values applied in the code.
--

commit 7c145dd0880cd69d24f8148542c77c20c1d72e64
Author: Ian Rogers <irogers@google.com>

perf tests: Speed up off-cpu profiling tests

This commit speeds up off-cpu profiling tests by scaling down the workload
durations and off-cpu threshold configurations, reducing the raw test
sleep overhead from 3.0s to 0.3s.

> - Change the above-threshold test to use `--off-cpu-thresh 99` and `sleep 0.1`.
> - Change the below-threshold test to use `--off-cpu-thresh 120` and `sleep 0.1`.

[Severity: Medium]
Are these threshold descriptions accurate?

Looking at test_offcpu_above_thresh() in
tools/perf/tests/shell/record_offcpu.sh, the implementation actually uses
a 50ms threshold:

    if ! perf record -e dummy --off-cpu --off-cpu-thresh 50 -o ${perfdata} -- sleep 0.1 2> /dev/null

Similarly, test_offcpu_below_thresh() implements a 500ms threshold instead
of 120ms:

    if ! perf record -e dummy --off-cpu --off-cpu-thresh 500 -o ${perfdata} -- sleep 0.1 2> /dev/null

While these implemented values provide a safer margin against execution
jitter, could this commit message regression be updated to match the actual
code?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616061404.41929-1-irogers@google.com?part=10