Re: [PATCH 7/7] hwmon: adm1275: Support module auto-loading

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

New issues:
- [Low] The commit message incorrectly references `spi_device_id` instead of `i2c_device_id`.

Pre-existing issues:
- [High] The newly added `adm1275_of_match` table is incomplete, leaving module auto-loading broken for the majority of supported devices.
--

commit ed700404448bb29c6f451edcac6e84d5a0f95644
Author: Matti Vaittinen <mazziesaccount@gmail.com>

    hwmon: adm1275: Support module auto-loading

This commit adds an of_device_id table to the adm1275 driver to enable
automatic module loading when devices are parsed from the device tree
at boot.

>     hwmon: adm1275: Support module auto-loading
>     
>     Populating the spi_device_id -table is not enough to make the

[Severity: Low]
This isn't a bug, but there's a typo in the commit message. The driver
is an I2C driver and uses an i2c_device_id table, not an spi_device_id
table.

[ ... ]

> diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
> index 9e21dd4083e94..c27bb0e493547 100644
> --- a/drivers/hwmon/pmbus/adm1275.c
> +++ b/drivers/hwmon/pmbus/adm1275.c
> @@ -927,9 +927,17 @@ static int adm1275_probe(struct i2c_client *client)
>  	return pmbus_do_probe(client, info);
>  }
>  
> +static const struct of_device_id adm1275_of_match[] = {
> +	{ .compatible = "rohm,bd12780", },
> +	{ .compatible = "rohm,bd12790", },

[Severity: High]
This is a pre-existing issue, but the newly added adm1275_of_match
table appears to be incomplete.

Since udev relies on the of_device_id table to export the correct
MODALIAS for auto-loading, wouldn't omitting the other devices
supported by this driver (such as adm1075, adm1275, adm1276) leave
auto-loading broken for those devices on DT systems?

Should we include compatible strings for the rest of the supported
hardware here to ensure they also benefit from module auto-loading?

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, adm1275_of_match);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1781591132.git.mazziesaccount@gmail.com?part=7