From: Simon Horman <horms@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: amakarov@marvell.com, davem@davemloft.net,
jesse.brandeburg@intel.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
richardcochran@gmail.com, andrew+netdev@lunn.ch,
edumazet@google.com, pabeni@redhat.com, sgoutham@marvell.com
Subject: Re: [PATCH net] octeontx2-pf: Fix leak of SQ timestamp buffer on teardown
Date: Tue, 16 Jun 2026 08:10:23 +0100 [thread overview]
Message-ID: <20260616071023.GP712698@horms.kernel.org> (raw)
In-Reply-To: <20260615030704.504536-1-rkannoth@marvell.com>
On Mon, Jun 15, 2026 at 08:37:04AM +0530, Ratheesh Kannoth wrote:
> The send-queue timestamp ring is allocated with qmem_alloc() when
> timestamping is used, but otx2_free_sq_res() never freed sq->timestamps,
> leaking that memory across ifdown and device removal. Add the missing
> qmem_free() alongside the other SQ companion buffers.
>
> Fixes: c9c12d339d93 ("octeontx2-pf: Add support for PTP clock")
> Cc: Aleksey Makarov <amakarov@marvell.com>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-06-16 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 3:07 [PATCH net] octeontx2-pf: Fix leak of SQ timestamp buffer on teardown Ratheesh Kannoth
2026-06-16 7:10 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616071023.GP712698@horms.kernel.org \
--to=horms@kernel.org \
--cc=amakarov@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.