From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 815633370EA; Tue, 16 Jun 2026 15:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622447; cv=none; b=e++gs7PCdD+LMpYRNGIqXsdaWLhvHnIhnvETnRwON+a8gGvsNjxOWuhhoukpmq4w+CtVdplH/JNwFHhpR4tzE2m1OEumu84gDPupsGZVuoFajz38MjbLRmtD9rt2qgzi7mPg/MQHb9/2FQ31vt2B1qxN+ZcMbub74UtetJrZq68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622447; c=relaxed/simple; bh=z1TF7B7XeN9/uFBlmncRwLn+Ra4uSP4Szhh9LsxGPQs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Poh9grut3rHdKjdVx6ZOG7lWubjeCWwtlTcq07BJxipVK9Vbdoh+1663TduGQI/G/zMaxML2ZT68Wc2Bar2x038vp/TzxetJtSSzEkR6NLz2toI8gPhVZdTj+JXsrUmKyib3+YqAF1lygL1xQVqTxPph7s7bKrhtUyig2uK0gTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aZG8JcDb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aZG8JcDb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 274F61F000E9; Tue, 16 Jun 2026 15:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781622446; bh=KNVv9ooOdPt4gDQz9b3gx0JN5sbG1rJmvfll/bOWLP4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=aZG8JcDbtDdPMer8gahR3+Hxh/jL/eqiKUDl/uBBRl5RBJcFCSsjs4mh/e2mesDVt CDfMQ6pquhUPGsno/0bwQr9n6y2w/V2YlH4gn0YW18R5Cu5SYMRcqRUrwK7Rr/xesZ NOq0T+yyGkrUNX3LKXyvx4+8hIjiFFgnL5CdOEyM7agauR8r1aEB/K2fVFSdi6pa7p sT+tcGyqSbVCHiR4AkOz8+ewHv4nCR0AvStJ3V/7sv9Hn0MbowuCkJwzMVsIvvqpHQ WvHlogKq3i29sduKqEY+DEfFrgwHfOiwnyo/FeCYvhl6eQeoQ8TdtGpi+HD91NpLeP NoHYYg3bvgLzA== Date: Tue, 16 Jun 2026 08:07:24 -0700 From: Jakub Kicinski To: Meghana Malladi Cc: , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v7 2/2] net: ti: icssg-prueth: Add ethtool ops for Frame Preemption MAC Merge Message-ID: <20260616080724.0d838fd6@kernel.org> In-Reply-To: References: <20260610052511.781752-3-m-malladi@ti.com> <20260615231041.1007484-1-kuba@kernel.org> <20260615163932.50bb3df0@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 16 Jun 2026 18:24:22 +0530 Meghana Malladi wrote: > >> Could the firmware-register lookup table used by emac_get_stat_by_name() > >> be separated from the ethtool -S string table, so the new preemption > >> counters feed get_mm_stats without also showing up under ethtool -S? > > > > This -- not sure about the other complaints but this one looks legit. > > I agree that this is legit, but right now there is no other place holder > other than pa stats to put the mac merge firmware counters. I believe > the effort needs to go in re-structuring the hardware and firmware stats > implementation to address this issue. icssg_all_miig_stats has a true / false that looks like it's supposed to serve the same purpose? Maybe I don't understand what you're trying to say