From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 554543DA7C2 for ; Tue, 16 Jun 2026 06:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781591290; cv=none; b=dpa+bT0QlzUihEZlC4pQj/cmcSPbcbtYksZgWXOJN/BCDOdT6YX6TCUaprWJHHaMTsaifKZGsfn89XVva9ASFf64RJ1wR1sNSd1DQG3Lelj78HORtvKCNUqU8uj8ipayM3c3+1Ohiab75I+mVHBftaZHY30TwKggOIkFVfecHUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781591290; c=relaxed/simple; bh=VF0vVCalwoKiothIU/EZPxYbbI+YQURbd4iFqg3U6jU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=irUIz29l7to61cFFuoSbc9CVyIsv9KynGb7Q7mRuWymbmRKOR+GtrYiKJ6P/JDGbVlMYBzkPvYW0FlJZs5jbFd0Tar03/2cgZdHqng33pZbLnFJ66V3xd/RmO1D5+G6KDGoHrxVOtREE1b0urrJwPulh8r0w5gvHhgc0KnuY8xk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RnQ9f+CZ; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RnQ9f+CZ" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 0AF5FC2BB2E; Tue, 16 Jun 2026 06:28:11 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7B9D1601A9; Tue, 16 Jun 2026 06:28:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C0F39106C9995; Tue, 16 Jun 2026 08:28:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1781591286; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=xqDreIRU1gIBcBWkRb2rib59VN988K1PRz9taykhfqs=; b=RnQ9f+CZYCqdXZX8j/SdZ5fm8hlToIes/tpRQXJOREid4IGEiIkd1o5kNMVf0/Z3GqON9n 3TSxmpDs/fc+02+VyT1YcuBCX+oHOkhX/HmAiWKIvXYrlRi1YjDU0NF9wXnzj4em4LeUlz 4HfTSA806U6zl63vYt5raMQS1mkOdSL4JtU3WyyFvRxVsyL6AgJyyI+ZUBBW6peBuOhx6A fsEs+l26MGDYBburzz2W/w6u07cOJxdrHfzPPTniFan0wRgQmrH1BPLO2vtQgyFS76WHeZ BYWYb/8OKMgVz64c1QOQF1IeSD94V4sgRTkeNEwMBOndgnnBRElyXRomm3B/IQ== Date: Tue, 16 Jun 2026 08:28:02 +0200 From: Herve Codina To: Pengpeng Hou Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: lan966x_pci: depopulate children on populate failure Message-ID: <20260616082802.76ecfd70@bootlin.com> In-Reply-To: <20260616004304.95117-1-pengpeng@iscas.ac.cn> References: <20260616004304.95117-1-pengpeng@iscas.ac.cn> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Pengpeng, On Tue, 16 Jun 2026 08:43:04 +0800 Pengpeng Hou wrote: > lan966x_pci_probe() loads the device-tree overlay and then populates > child devices from it. If of_platform_default_populate() fails after > creating any children, the error path removes the overlay without first > depopulating the partially-created children. > > Mirror the remove path ordering on the populate failure path by > depopulating child devices before unloading the overlay. > > Signed-off-by: Pengpeng Hou > --- > drivers/misc/lan966x_pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Indeed, thanks for the patch. Reviewed-by: Herve Codina Best regards, Hervé