From: linuxtestproject.agent@gmail.com
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] connect01: Convert to new API
Date: Tue, 16 Jun 2026 08:35:24 +0000 [thread overview]
Message-ID: <20260616083524.4087-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260616052452.8353-2-wegao@suse.com>
Hi Wei,
On Tue, Jun 16, 2026, Wei Gao wrote:
> connect01: Convert to new API
--- [PATCH 2/2] ---
> + .needs_root = 1,
Ground Rule 4 requires the doc comment to explain why root is
needed. The EACCES case drops to nobody via SAFE_SETUID, which
requires starting as root. Could the doc block mention this?
For example:
/*\
* Verify that :manpage:`connect(2)` returns the proper errno
* for various failure cases.
*
* Requires root to test EACCES by dropping privileges to an
* unprivileged user.
*/
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-16 8:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 4:51 [LTP] [PATCH v2 1/2] connect01: Convert to new API Yang Xu via ltp
2024-05-14 4:51 ` [LTP] [PATCH v2 2/2] connect01: Add negative tests Yang Xu via ltp
2024-07-17 12:30 ` [LTP] [PATCH v2 1/2] connect01: Convert to new API Cyril Hrubis
2026-05-25 9:02 ` [LTP] [PATCH v3 0/2] " Wei Gao via ltp
2026-05-25 9:02 ` [LTP] [PATCH v3 1/2] " Wei Gao via ltp
2026-05-25 10:12 ` [LTP] " linuxtestproject.agent
2026-05-28 4:43 ` Wei Gao via ltp
2026-06-04 4:49 ` [LTP] [PATCH v4 0/2] " Wei Gao via ltp
2026-06-04 4:49 ` [LTP] [PATCH v4 1/2] " Wei Gao via ltp
2026-06-04 7:15 ` [LTP] " linuxtestproject.agent
2026-06-16 1:47 ` [LTP] [PATCH v5 0/2] " Wei Gao via ltp
2026-06-16 1:47 ` [LTP] [PATCH v5 1/2] " Wei Gao via ltp
2026-06-16 4:07 ` [LTP] " linuxtestproject.agent
2026-06-16 5:24 ` [LTP] [PATCH v6 0/2] " Wei Gao via ltp
2026-06-16 5:24 ` [LTP] [PATCH v6 1/2] " Wei Gao via ltp
2026-06-16 8:35 ` linuxtestproject.agent [this message]
2026-06-16 9:31 ` [LTP] [PATCH v7 0/2] " Wei Gao via ltp
2026-06-16 9:31 ` [LTP] [PATCH v7 1/2] " Wei Gao via ltp
2026-06-16 10:12 ` [LTP] " linuxtestproject.agent
2026-06-16 9:31 ` [LTP] [PATCH v7 2/2] connect01: Add negative tests Wei Gao via ltp
2026-06-16 5:24 ` [LTP] [PATCH v6 " Wei Gao via ltp
2026-06-16 1:47 ` [LTP] [PATCH v5 " Wei Gao via ltp
2026-06-04 4:49 ` [LTP] [PATCH v4 " Wei Gao via ltp
2026-05-25 9:02 ` [LTP] [PATCH v3 " Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616083524.4087-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.