Re: [PATCH v2 2/6] rust: sync: Add abstraction for rcu_barrier()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#[inline]` annotation on the `rcu_barrier` abstraction function.
--

commit 429e3c9d9e99f90b82501282309c58b5cf00107c
Author: Philipp Stanner <phasta@kernel.org>

rust: sync: Add abstraction for rcu_barrier()

This commit introduces a safe Rust abstraction for the C function
rcu_barrier(), allowing Rust code to wait for all pending call_rcu()
callbacks to complete.

> diff --git a/rust/kernel/sync/rcu.rs b/rust/kernel/sync/rcu.rs
> index a32bef6e490b0..eef34bf862596 100644
> --- a/rust/kernel/sync/rcu.rs
> +++ b/rust/kernel/sync/rcu.rs
[ ... ]
> +/// Wait for all pending call_rcu() callbacks, if there are any.
> +pub fn rcu_barrier() {

[Severity: Low]
This isn't a bug, but should this abstraction function be annotated with
#[inline]? The Rust subsystem guidelines indicate that small functions
or those that simply forward to a binding call should include the inline
annotation.

> +    // SAFETY: `rcu_barrier()` is always safe to be called. It just might wait for a grace period.
> +    unsafe { bindings::rcu_barrier() };
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260616082819.2943886-2-phasta@kernel.org?part=2