From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB858CD98CF for ; Tue, 16 Jun 2026 10:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VB30rtJpcdWBkSfUltG7JO/Quqnck+I6SLFAjV+j994=; b=n1cSjS1bDjbXnF Ac6RRZwaMtWqwIxi5rnEG+oQSCGYliACacgU1Uhafju2IF7L5DDJz1EyXN3ysdLtaP2+rIddGLfEk 6u94OF1BGalncrK6oVDPvEC9Gw67gz+ftPZ2m2L1sRuMhA29v4gPEi3TA4+JP2KDj91Eg8xS+U8tC 0frXsfuAACFcvAPpZrOXPsNv9sFSXCCNQWmla2PVRGmfXmngtdtpDABZzGT33KLV4ccboQ82fkPiI jntgvC+bFE0VDVq9+F0VrcH3A9g/RCSEyE1aE6OvrJ7KDCk0eJA9K10mTZyoVOyD70a4hQiihGD0U AsPLNh3B15jWCWoPvi1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZR4M-0000000Fbyo-21Vq; Tue, 16 Jun 2026 10:30:58 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZR4L-0000000Fbyi-2Uef for linux-i3c@lists.infradead.org; Tue, 16 Jun 2026 10:30:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 035CB43832; Tue, 16 Jun 2026 10:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F6161F00A3D; Tue, 16 Jun 2026 10:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781605856; bh=FwC59B4n0rf5OGJgDzl9cyHnls6ke/WWYBAyLmv+7gw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=H0phtaJn/lZL+Gaioo/8scIgU1c0Y5hrikbqp9MQK7l2HUt6tS0inRk4Ir6u9u+aP 5WqqB0/f9ttMvqFTZV8rebA911Su7EDHqbNe6tM7GX0GErN8sshLvTbsvjDRAqs3sP 7yHElXO1GdySkuqT+gGcys1kURHh/DLkK0GXM/V4ZQ68ltgnz4swwM5sOXatVH7psy xnRHCd3enQkBUVVt86R5GM8Pwc60OPyE7l574leThLexMTrJvmRknvMG1zP58OSbXY PZyWFcXhaKaVLUv19c+aTNo3xQlxfwiFZ+IOTkt5mLPC7giQbu4McI+SobGucc2Utw yaQsM79qQfDvQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 11/12] hwmon: spd5118: Add I3C support To: "Akhil R" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, Frank.Li@kernel.org In-Reply-To: <20260616095429.3947205-12-akhilrajeev@nvidia.com> References: <20260616095429.3947205-12-akhilrajeev@nvidia.com> Date: Tue, 16 Jun 2026 10:30:55 +0000 Message-Id: <20260616103056.6F6161F00A3D@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org PiBBZGQgYSByZWdtYXAgY29uZmlnIGFuZCBhIHByb2JlIGZ1bmN0aW9uIHRvIHN1cHBvcnQgSTND LWJhc2VkCj4gY29tbXVuaWNhdGlvbiB3aXRoIFNQRDUxMTggZGV2aWNlcy4KPiAKPiBPbiBhbiBJ M0MgYnVzLCBTUEQ1MTE4IGRldmljZXMgYXJlIGVudW1lcmF0ZWQgdmlhIFNFVEFBU0EgYW5kIGFs d2F5cwo+IHJlcXVpcmUgYW4gQUNQSSBvciBkZXZpY2UgdHJlZSBlbnRyeS4gRGV2aWNlIG1hdGNo aW5nIGlzIGhlbmNlIHRocm91Z2gKPiB0aGUgT0YgbWF0Y2ggdGFibGVzIG9ubHkgYW5kIGRvZXMg bm90IG5lZWQgYW4gSTNDIGNsYXNzIG1hdGNoIHRhYmxlLiBUaGUKPiBkZXZpY2UgaWRlbnRpdHkg aXMgdmVyaWZpZWQgaW4gdGhlIHR5cGUgcmVnaXN0ZXJzIGJlZm9yZSBwcm9jZWVkaW5nIHRvCj4g dGhlIGNvbW1vbiBwcm9iZSBmdW5jdGlvbi4KPiAKPiBBY2tlZC1ieTogR3VlbnRlciBSb2VjayA8 bGludXhAcm9lY2stdXMubmV0Pgo+IFNpZ25lZC1vZmYtYnk6IEFraGlsIFIgPGFraGlscmFqZWV2 QG52aWRpYS5jb20+CgpTYXNoaWtvIGhhcyByZXZpZXdlZCB0aGlzIHBhdGNoIGFuZCBmb3VuZCBu byBpc3N1ZXMuIEl0IGxvb2tzIGdyZWF0IQoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBz Oi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDYxNjA5NTQyOS4zOTQ3MjA1LTEtYWtoaWxy YWplZXZAbnZpZGlhLmNvbT9wYXJ0PTExCgoKLS0gCmxpbnV4LWkzYyBtYWlsaW5nIGxpc3QKbGlu dXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1pM2MK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 520303546E3; Tue, 16 Jun 2026 10:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781605858; cv=none; b=PIuDFjxzA7jSgtcFSIO3uxYnySuDEehyj2IRk8iBekqdUmq5Qtiu3LRVoSNNXRTgPz/X07qQSadZCrXZMeYjAGFPfgwp4A8QIX5JXPV37/SRI5zVLSJWHbFuy6yKAmRgJnRWFNUgZkXz+iBf2NlgxAulUsTDTNFkgvflvdmC5dQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781605858; c=relaxed/simple; bh=FwC59B4n0rf5OGJgDzl9cyHnls6ke/WWYBAyLmv+7gw=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=QR7krIkGRBEfQEr3+fH1SqGYV/1ZIRm7S+j512QyIIf/TatoaAmkTqPexl2hSIsx9ywP5+AvcA7pj+EpEOss8qJ9LjrKa5NpolDWE7NJ7cck9otpwdoO+IZsEkeh4WhopxUa+lGUleiO2BeIFG3a5NLWan8PGSerNRnz04LyGps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H0phtaJn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H0phtaJn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F6161F00A3D; Tue, 16 Jun 2026 10:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781605856; bh=FwC59B4n0rf5OGJgDzl9cyHnls6ke/WWYBAyLmv+7gw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=H0phtaJn/lZL+Gaioo/8scIgU1c0Y5hrikbqp9MQK7l2HUt6tS0inRk4Ir6u9u+aP 5WqqB0/f9ttMvqFTZV8rebA911Su7EDHqbNe6tM7GX0GErN8sshLvTbsvjDRAqs3sP 7yHElXO1GdySkuqT+gGcys1kURHh/DLkK0GXM/V4ZQ68ltgnz4swwM5sOXatVH7psy xnRHCd3enQkBUVVt86R5GM8Pwc60OPyE7l574leThLexMTrJvmRknvMG1zP58OSbXY PZyWFcXhaKaVLUv19c+aTNo3xQlxfwiFZ+IOTkt5mLPC7giQbu4McI+SobGucc2Utw yaQsM79qQfDvQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 11/12] hwmon: spd5118: Add I3C support Reply-To: sashiko-reviews@lists.linux.dev To: "Akhil R" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, Frank.Li@kernel.org In-Reply-To: <20260616095429.3947205-12-akhilrajeev@nvidia.com> References: <20260616095429.3947205-12-akhilrajeev@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 16 Jun 2026 10:30:55 +0000 Message-Id: <20260616103056.6F6161F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Add a regmap config and a probe function to support I3C-based > communication with SPD5118 devices. >=20 > On an I3C bus, SPD5118 devices are enumerated via SETAASA and always > require an ACPI or device tree entry. Device matching is hence through > the OF match tables only and does not need an I3C class match table. The > device identity is verified in the type registers before proceeding to > the common probe function. >=20 > Acked-by: Guenter Roeck > Signed-off-by: Akhil R Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260616095429.3947= 205-1-akhilrajeev@nvidia.com?part=3D11