From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 924B1CD98E1 for ; Tue, 16 Jun 2026 17:31:40 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1339539.1600756 (Exim 4.92) (envelope-from ) id 1wZXdM-0008St-4F; Tue, 16 Jun 2026 17:31:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1339539.1600756; Tue, 16 Jun 2026 17:31:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZXdM-0008Sm-18; Tue, 16 Jun 2026 17:31:32 +0000 Received: by outflank-mailman (input) for mailman id 1339539; Tue, 16 Jun 2026 17:31:30 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZXdK-0008Sa-Cn for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 17:31:30 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wZXdJ-006bOT-Ph for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 19:31:29 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a318857-5cb7-0a2a0a5109dd-0a2a4501b2b0-38 for ; Tue, 16 Jun 2026 19:31:29 +0200 Received: from [170.10.129.124] (helo=us-smtp-delivery-124.mimecast.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a318870-c1f2-0a2a45010019-aa0a817c9759-3 for ; Tue, 16 Jun 2026 19:31:29 +0200 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-w7l57zGDNGGApvl0l7CbGg-1; Tue, 16 Jun 2026 13:31:26 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490b8adf8b8so45282405e9.0 for ; Tue, 16 Jun 2026 10:31:26 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923343cb75sm3583875e9.0.2026.06.16.10.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 10:31:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=mimecast20190719 header.d=redhat.com header.i="@redhat.com" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781631088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZWc8XpFSVDFqkdh9JRMAyyd+HTlraBz0TXBtpxzGEaY=; b=RjCtsuHAMqzKrlzaO4Amt3BhMQRDJH4P2dFt+nB1nNgSwhQuUkjDjhsccTFZ0KTRE/5ac6 RmW1Z3TwNj/nLdyTolrQjbDARZns+CZ2QmDmSos8MXvR0zIqioepUjG6VZMSiwwWNpaP5G Bu2ZE3ZFn88Zd9Iqsz0ze6DEvhUwIf8= X-MC-Unique: w7l57zGDNGGApvl0l7CbGg-1 X-Mimecast-MFC-AGG-ID: w7l57zGDNGGApvl0l7CbGg_1781631086 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781631085; x=1782235885; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZWc8XpFSVDFqkdh9JRMAyyd+HTlraBz0TXBtpxzGEaY=; b=SFmtZsnC5UW5Bi2M15KcdxCNlPsn3AUKvzEr9NWc2YNNnrFtlHcYN1BycwvpVpX/ai XU/HdYYCU2nuh1RWg9Yc/VvfuWZ63d8u10Hs9CY4CzauYdpnRNnqLiEFUo01Ha9I1BZ+ 7Fp1F4cNW43dvQonkADaOjTiak0HSbb3AUQHS7rIenlRuCtHjAOVmp5M99NsAGknxJKy go6xaE6NkUSbqfos7WvkR+JsgcemVqaW3sIXxgiO5ZtMqqjlbI+FITphxzD/oBFe4Xwe BkKIXj5y4jLXuLxOHRwM4v2/5NWrA3YOkndMoBDk8V23DHaNGRGlxMKNKG4GUPnQPErw NTKA== X-Forwarded-Encrypted: i=1; AFNElJ/c0jNOllju0+Z9KaRoVrtO/EaFjOWdcmSuJMh15cjtC5/BzyhDu4Kmbns5g90G5l3/JFl/FTPTIEw=@lists.xenproject.org X-Gm-Message-State: AOJu0YwK22uXMIm/Doji0/owZ5pBgROIt6QskGP9ykVPqTGKKBkWLGId 4Q516TZAMVU/Z25AW4ftIS7B0yWGjNEespUr9aAmQqe7EH4qsgSEn0uu02Is6JrJCcD6IKLixHc wJg6wMsMfrYJMQv/jPrZjX1fIpALVYE12688AnbZd4z4bRBWbfOY49FdYhSpgpD13/bgi X-Gm-Gg: Acq92OHjz5X7K3zuGXR1ucNyYt3vfvo5assbV7Bd/eF0AqRqAxJeKoFbCXrwaQA/p6H GaWc/JsOecbTuJTgIE//NSv1zjgoM0D1sxkgTsb5jeC49w6VcozesUPtR7ri5GqU+GEIEQOeHIB NqYJSgCGW/EF1gkwybGV2bPmYO7SrPrBgmqCEdxes8mViubOQ7zawOzYINdUAxLZaobl2swDSsg 3EBgfe7V741vBMoKnJeHlKwsOft/vG8iZSkp+PV61PaWgCT9SN2jng4AxB+7j1rXQS3D4XFM8Az zVpxm47PAPOigVKgbstIytBMmMYKdP+Jb5n4yspaBykRJG/6OMInKDNQAU1oT9o3uS3YzCtO0kK tYSMdk2ZS4aS/Vjpc2uGxQYXHhiNa0Xa6i9J3BZ5Ubrk= X-Received: by 2002:a05:600d:8496:20b0:490:e913:656a with SMTP id 5b1f17b1804b1-492333d8ae7mr6321255e9.27.1781631085390; Tue, 16 Jun 2026 10:31:25 -0700 (PDT) X-Received: by 2002:a05:600d:8496:20b0:490:e913:656a with SMTP id 5b1f17b1804b1-492333d8ae7mr6320565e9.27.1781631084806; Tue, 16 Jun 2026 10:31:24 -0700 (PDT) Date: Tue, 16 Jun 2026 13:31:21 -0400 From: "Michael S. Tsirkin" To: Michael Tokarev Cc: Thierry Escande , qemu-devel@nongnu.org, Alexey Gerasimenko , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Anthony PERARD , xen-devel@lists.xenproject.org, qemu-stable Subject: Re: [PATCH 3/4] q35: Fix incorrect values for PCIEXBAR masks Message-ID: <20260616133032-mutt-send-email-mst@kernel.org> References: <20260313164649.794591-1-thierry.escande@vates.tech> <20260313164649.794591-4-thierry.escande@vates.tech> <46238511-ed5d-4f2d-881d-87120e4a408d@tls.msk.ru> MIME-Version: 1.0 In-Reply-To: <46238511-ed5d-4f2d-881d-87120e4a408d@tls.msk.ru> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pmlMyhYbFd-A7gZHn-mSpbfV4VSK05n6t9-aHMb3j5k_1781631086 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-purgate-ID: tlsNG-d62444/1781631089-ACE52FF4-22EAFE7F/0/0 X-purgate-type: clean X-purgate-size: 876 On Tue, Jun 16, 2026 at 07:25:52PM +0300, Michael Tokarev wrote: > On 13.03.2026 19:47, Thierry Escande wrote: > > From: Alexey Gerasimenko > > > > There are two small issues in PCIEXBAR address mask handling: > > - wrong bit positions for address mask bits (see PCIEXBAR description > > in Q35 datasheet) > > - incorrect usage of 64ADR_MASK > > > > Due to this, attempting to write a valid PCIEXBAR address may cause it > > to shift to another address, causing memory layout corruption where > > emulated MMIO regions may overlap real (passed through) MMIO ranges. Fix > > this by providing correct values. > > I'm not sure about the implication of this issue, - is it qemu-stable > material? > > Thanks, > > /mjt I think yes generally, but it worries me this has a high risk for breaking migration if I missed something.