From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EDA7212D7C; Tue, 16 Jun 2026 13:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617382; cv=none; b=uqrERghjx6mKyahtsiU/8dFyXp2UGHTYgLBMBy3YWpBJGgWYDmGj2vZVqt6ecPh+U5bTaOxkKP8kFSgJ5Q7d1LyK/+mbOBL0F+nsYowbHShOJ5pCAinkmrAxorsWjOvn1phBRsja/MI4dGmDLG/AQpY63s49DRqvUDBMKYRbv7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781617382; c=relaxed/simple; bh=y15Ipf+iIGRKuRBcXNk+ZyGkGCPpvE+tgNuodC+FHrk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iGbh31oeUJ6k1hwO8pMRvFXPQsoOMFzOGNw5fTAvhBQYBiPzXVBa8pTTVJPEjIBv31uzRMK32P3YDnJqTUGJLirKuWFL4LTAAjxxQJqpERlJvadbvQaOrBkYpOVYr+Wr3SIezCgMJokKOjksTSBYuoPi3KQQA1qFgB1SGhUWcFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PNZUueQn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PNZUueQn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FF891F000E9; Tue, 16 Jun 2026 13:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781617380; bh=BlUDip4GcgFnSaDcETbB3mXqYyAfrmdK96aHUTtbFQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=PNZUueQn/N4W6+A2fF7S/sYZIxI8SXTR0Skm5X8h8nfTGlv84Fon2rm/DtaEJg3r3 e16LAo5QpqSa3Ajpzs+d+SCI9WeuNBJUWrsVKuRHRyhUesel17fQLiVEbVH0wfilSI Gu+jftp3/UFCJbEzSXLg0SlyZj2XB9n2nnNHlyUDLwpll50BNP6PrRqa/VzW7Q+Kli rPBmDSDe19h5pP3/eJaX273BzmG0LLTdaEDdi+pf1aF+viiZ1gaGBSmZt3/aEihk2e STt9qq3EqUxMY4FxceCxgs63/XTLTB+pgnPPNJmt/3i7Pp9wnaryNn8ghYX57fvpym fQTpXQVmghpbw== Date: Tue, 16 Jun 2026 08:42:57 -0500 From: Rob Herring To: Luca Leonardo Scorcia Cc: linux-mediatek@lists.infradead.org, Dmitry Torokhov , Krzysztof Kozlowski , Conor Dooley , Sen Chu , Sean Wang , Macpaul Lin , Lee Jones , Matthias Brugger , AngeloGioacchino Del Regno , Liam Girdwood , Mark Brown , Linus Walleij , Julien Massot , Louis-Alexis Eyraud , Val Packett , Fabien Parent , Akari Tsuyukusa , Chen Zhong , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v7 0/9] Add support for MT6392 PMIC Message-ID: <20260616134257.GB2335264-robh@kernel.org> References: <20260615071836.362883-1-l.scorcia@gmail.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615071836.362883-1-l.scorcia@gmail.com> On Mon, Jun 15, 2026 at 09:16:06AM +0200, Luca Leonardo Scorcia wrote: > The MediaTek MT6392 PMIC is usually found on devices powered by > the MT8516/MT8167 SoC and is yet another MT6323/MT6397 variant. > > This series is mostly based around patches submitted a couple > years ago by Fabien Parent and not merged and from Val Packett's > submission from Jan 2025 that included extra cleanups, fixes, and a > new dtsi file similar to ones that exist for other PMICs. Some > comments weren't addressed and the series was ultimately not merged. > > These patches enable four functions: keys, regulator, pinctrl and RTC. > Mono speaker amp will follow later as I need to work further on the > audio codec. > > I added a handful of device tree improvements to fix some dtbs_check > errors, added support for the pinctrl device and addressed the comments > from last year's reviews. > > Please note that patch 0006 and 0008 depend on patch 0005 as they need the > registers.h file, but belong to different driver areas. I'm not sure if > I'm supposed to squash them even if they belong to different driver > areas of if it's fine like this. Any advice is welcome. > > The series has been tested on Xiaomi Mi Smart Clock X04G and on the > Lenovo Smart Clock 2 CD-24502F. > > Changes in v7: > - Removed patch 0008 dependency on patch 0003. > - Reintroduced the regulator driver. In earlier revisions of this series, > it was proposed to remove the dedicated compatible for the regulator > device [3]. The driver does not use actually it, but it is not possible > at this time to remove it from the bindings since it's a required > property. > > Making the regulator-required property conditional was NACKed in [5], > with the suggestion to create a separate binding altogether for devices > that do not require the compatible property. I tried implementing this, > but since the parent device needs to be declared as compatible with > mt6323, it leads to a warning in dt_binding_check since mt6323 would > be declared as a compatible in both mt6392 and mt6397. > > In the end the only regulator driver from the mt6397 documentation that > still declares an of_match is mt6397-regulator and it does not seem > to be necessary, so it should be possible to remove it and make the > regulator compatible optional for all regulators, but that change would > probably deserve its own separate patch series. I don't really follow what the issue is here, but compatible should never be optional. Rob