From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C89F747B435; Tue, 16 Jun 2026 18:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636150; cv=none; b=QFaGHJu394Vmt5fZeW/TUYXwT9SvFA0mu8bgOx4KZTPKNy1DsZHOq8U5KbCXWJ04Er/llC5B+rQQc6H4TlJ2OU8uk5xWpzUyN1/Q530PmavJXeCK/2meTpkqKlWra53ZvDi19AbUVXBkHtQAl8Q1Rcis8hWta6SrjrInv5akqms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636150; c=relaxed/simple; bh=z/tpMibkO1QsM30NPpEFH2pwVHXaX5l8JnM4NsnpWDs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rf0XZHnLla9RbQOmu8HvN8/IO2jrqKeGf267eFkr3DAxDHHuvVRdqlKlKUHlkq3HCZz9c7eqks99+JoawCMuswmv/RsKL4XFjyuQrECRauKzr0AGeMKWDjLdeeQrMMshm/PS0H1PI/jdqY6Xgr91EySwR6VWJFHoSrhvoqUPkL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EtNbfOXV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EtNbfOXV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0EE21F000E9; Tue, 16 Jun 2026 18:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636149; bh=t9bBEBhouHBTL7Qj/gWwEt37uxI0bAOjuZbhAcIQaWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EtNbfOXVEQx+7aPYbBzcNTFqSsAgSnSZMIbaGIUxqJETWMbt1lsUPhwh8svl6brsv 1HHXI6fULZZ0OX/P0yn1NqmfsYrdeBvOmGHtviOaT914o0qEkrY3O8FQgbGcQwrXsj gF07RWVAu8pEUAaDSup7f4ojLadTyOLOvjQC9JXI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiang Mei , Weiming Shi , Dongli Zhang , Willem de Bruijn , Jakub Kicinski , Harshit Mogalapalli , Sasha Levin Subject: [PATCH 5.10 161/342] tun: free page on build_skb failure in tun_xdp_one() Date: Tue, 16 Jun 2026 20:27:37 +0530 Message-ID: <20260616145055.665903685@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Weiming Shi [ Upstream commit aa8963fdce667a42fb7f0bdd2909fadcab02f9a8 ] When build_skb() fails in tun_xdp_one(), the function sets ret to -ENOMEM and jumps to the out label, which returns without freeing the page that vhost_net_build_xdp() allocated for the frame. As with the short-frame rejection path, tun_sendmsg() discards the per-buffer error and still returns total_len, so vhost_tx_batch() takes the success path and never frees the page. Each build_skb() failure in a batch leaks one page-frag chunk. Free the page before taking the error path, matching the put_page() the other error exits of tun_xdp_one() already perform. Fixes: 043d222f93ab ("tuntap: accept an array of XDP buffs through sendmsg()") Reported-by: Xiang Mei Signed-off-by: Weiming Shi Reviewed-by: Dongli Zhang Reviewed-by: Willem de Bruijn Link: https://patch.msgid.link/20260521163312.1479805-2-bestswngs@gmail.com Signed-off-by: Jakub Kicinski (cherry picked from commit aa8963fdce667a42fb7f0bdd2909fadcab02f9a8) [Harshit: Backport to 5.15.y/5.10.y, use err instead of ret, no change needed] Signed-off-by: Harshit Mogalapalli Signed-off-by: Sasha Levin --- drivers/net/tun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 930086d79f97c8..d960b261dbe4f6 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2518,6 +2518,7 @@ static int tun_xdp_one(struct tun_struct *tun, build: skb = build_skb(xdp->data_hard_start, buflen); if (!skb) { + put_page(virt_to_head_page(xdp->data)); err = -ENOMEM; goto out; } -- 2.53.0