From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31ED47CC7A; Tue, 16 Jun 2026 18:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636087; cv=none; b=UUno/nXb5W3z712KHk14kKNLor+T8ev2YMKqcy9OhEZ90dnkSNtCQXczY0xuJUSB49z+80vmo9h2yJAfhBYgS2NefuJKYm8FpZlsyF5r4bXOowzvbGe/6K34DJk+Ef6R1kj4jxN39yoxvYHxDbR26LViLQmfKWJke78slwQsiKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636087; c=relaxed/simple; bh=0/TIgY754gUb6rf8i9ZtEqhLUkawUXQxFKImtGq/Rac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UQ49HCgAXl9Auvyjq4q5rYwK6UTMZdcPm+RVAs/3BtPVwiO5/pqlSh6bVQAtpBEKOeqtxBztgfTQac3kyVigetjFhXxbdGSsl1cb2DC/tW3+zMCw6wNrY7RvCxheUTiRJCwWFD/XHs/5a3feEMGdo7q6XQfrah15ZLcTnPf7qdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PTb8+XVL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PTb8+XVL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D33E51F000E9; Tue, 16 Jun 2026 18:54:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636085; bh=IbG6u6aHne7+In4VUPl1qbfBW9yW/sVasOdzw8OZPXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PTb8+XVLiQtbN8Y6JE4ScPUxesFlK1pq7+FynCL6tW2g29k2M9AcDLP/2rsZkxv/Q FTeyaF+n1YZFZpXSPkECPKe84fQxJ042Ud5ChhDkY5dnyyjM7Q9sLeDblkIR3H+m3d FOUfaCUcYuBCcD9XiljqYO83FH5XOIfyjVqGimO0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Dumazet , Steffen Klassert , Nicolas Dichtel , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 173/342] ip6_vti: fix incorrect tunnel matching in vti6_tnl_lookup() Date: Tue, 16 Jun 2026 20:27:49 +0530 Message-ID: <20260616145056.260136332@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit a5c0359f5cbc51a2e2b114d6041e0f3c73f903e9 ] In vti6_tnl_lookup(), when an exact match for a tunnel fails, the code falls back to searching for wildcard tunnels: - Tunnels matching the packet's local address, with any remote address wildcard remote). - Tunnels matching the packet's remote address, with any local address (wildcard local). However, vti6 stores all these different types of tunnels in the same hash table (ip6n->tnls_r_l) prone to hash collisions. The bug is that the fallback search loops in vti6_tnl_lookup() were missing checks to ensure that the candidate tunnel actually has a wildcard address. Fixes: fbe68ee87522 ("vti6: Add a lookup method for tunnels with wildcard endpoints.") Signed-off-by: Eric Dumazet Cc: Steffen Klassert Reviewed-by: Nicolas Dichtel Link: https://patch.msgid.link/20260608164613.933023-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv6/ip6_vti.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c index 241e5191f43c15..e471a5821b0de5 100644 --- a/net/ipv6/ip6_vti.c +++ b/net/ipv6/ip6_vti.c @@ -105,6 +105,7 @@ vti6_tnl_lookup(struct net *net, const struct in6_addr *remote, hash = HASH(&any, local); for_each_vti6_tunnel_rcu(ip6n->tnls_r_l[hash]) { if (ipv6_addr_equal(local, &t->parms.laddr) && + ipv6_addr_any(&t->parms.raddr) && (t->dev->flags & IFF_UP)) return t; } @@ -112,6 +113,7 @@ vti6_tnl_lookup(struct net *net, const struct in6_addr *remote, hash = HASH(remote, &any); for_each_vti6_tunnel_rcu(ip6n->tnls_r_l[hash]) { if (ipv6_addr_equal(remote, &t->parms.raddr) && + ipv6_addr_any(&t->parms.laddr) && (t->dev->flags & IFF_UP)) return t; } -- 2.53.0