From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31F153CC303; Tue, 16 Jun 2026 18:55:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636141; cv=none; b=s0OCR6kmo+WmpPttXcMYA5ttGKRdIIXheYx5+6nlOVcPa4Tmq5mnxZT58tFcfkcEKHERKstP18tBrhq27lN7RTxiJLozDS4D5lzDjNwyf8REnJDeH7X9/ZXFHZ1ylGp8A/3LZuaFaho9Yzp7bXksYMZn38EAKRlGpsI/cnL7wos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636141; c=relaxed/simple; bh=THvcQ1NinK+XbRtoxXkRbm5txCGCJATIcs5QXJRrRoA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XkV7kRMpjdnCh7OcgjhBXWZhsiO7YUkYM53XBOxWqPhm6pBSBJdM60PP/XzzCIwdt1VHey8e+J4qQFOZ6k3rkbvanaNCe7SI+LsBdQ6WiXtM0J/kHuQdEj01qNxlEJPRUFOmRk3dEpigxhx02D1LklwPdyfps6pqN3Xsmp/qgqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=byXeb/Q0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="byXeb/Q0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39E831F00A3A; Tue, 16 Jun 2026 18:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636140; bh=oso/j5F/udEgVghBW+nYdy2EruzHVYee3DsOvM2G0r4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=byXeb/Q0sKcvLkR6yP7sZ16wDmHj5JHERCF78Gjmg6/SdxyvzN0mzJE/6zWEsFLrq XpecjHznU+1TBlm/U4Bj6JEq7dt4XbKg1SLHet4vq/tvlppz2rpRwMkKFQN76FtjU6 4wLwzyJUK20YrOi28Ac9dEswpb665yUadsMg56NQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Adrian Korwel , Johan Hovold Subject: [PATCH 5.10 182/342] USB: serial: io_ti: fix heap overflow in get_manuf_info() Date: Tue, 16 Jun 2026 20:27:58 +0530 Message-ID: <20260616145056.673502556@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Adrian Korwel commit 183c1076eca43bbb3e7bdf597456f91d81c73e74 upstream. get_manuf_info() reads le16_to_cpu(rom_desc->Size) bytes from the device I2C EEPROM into a buffer allocated with kmalloc_obj(), which is sizeof(struct edge_ti_manuf_descriptor) = 10 bytes. The Size field comes from the device and is only validated (in check_i2c_image()) to make sure the descriptor fits within TI_MAX_I2C_SIZE (16384 bytes), not against the destination buffer size. A malicious USB device can therefore set Size to any value up to 16377, causing a heap overflow of up to 16367 bytes when plugged into a host running this driver. valid_csum() is called after read_rom() and also iterates buffer[0..Size-1], compounding the out-of-bounds access. Fix by rejecting descriptors with unexpected length before calling read_rom(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Adrian Korwel [ johan: amend commit message; also check for short descriptors ] Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/io_ti.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/usb/serial/io_ti.c +++ b/drivers/usb/serial/io_ti.c @@ -776,6 +776,12 @@ static int get_manuf_info(struct edgepor } /* Read the descriptor data */ + if (le16_to_cpu(rom_desc->Size) != sizeof(struct edge_ti_manuf_descriptor)) { + dev_err(dev, "unexpected Edge descriptor length: %u\n", + le16_to_cpu(rom_desc->Size)); + status = -EINVAL; + goto exit; + } status = read_rom(serial, start_address+sizeof(struct ti_i2c_desc), le16_to_cpu(rom_desc->Size), buffer); if (status)