From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B2F547CC9C; Tue, 16 Jun 2026 18:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636315; cv=none; b=JLXqSNv1txQ21gC5kBxOc8IHoY1HXuo69T9fekrxuv2wb5xADiSdd84mfwiI/CfZ8JJ/gLgaB+IfigzKaOlEahWQzP/N+k2nVpDnpQIhKBNXGsCB7JMzHC7xkrbZkUz4yquW05zRqOgiFeltiohFB0g10Hd12nYQvpsU5D+YDig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636315; c=relaxed/simple; bh=mQSxHI0D6mCsx3673eYv5mRNAzrvyZiiCxsoEqGOKAQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iU5UQLMeUTSAynhHfcQLEeh+WD0KGP0xHvEpCSQOR9LxenV8onuoI3eG2mx5RuNq+DukbSSBoWHhTu+jK/u4ulK4+4J6tm1ozo+8vJwny0v/vSgSp2DGM3qs5H8wEw4ZxCQDTYITYqBCPM75rc1ldA3+2dNgaNT7DgyoiJUmYOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pIGMoT8S; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pIGMoT8S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4012E1F000E9; Tue, 16 Jun 2026 18:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636314; bh=QUvkZH7bS91agsGrxaHo+y6ofAP0Eo4S6Fp+bLzl4CM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=pIGMoT8S4+2a6sts3gppm3Kl2lmLtSBkFKIUpE6QrkEkG1I2oSsXGXQhqjqer/4rP btKeW8bYAatdrNk5kpi2n/SmPM0CsDJ4LiKIBn/i7E6Amc1TwjWOepPI9LfF+l2dQS O86TTl099UC1ZaEvTjXgDxKmfcLn4jYZA6bDjRXI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Raf Dickson , Stefano Garzarella , Paolo Abeni Subject: [PATCH 5.10 190/342] vsock/vmci: fix sk_ack_backlog leak on failed handshake Date: Tue, 16 Jun 2026 20:28:06 +0530 Message-ID: <20260616145057.031195014@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Raf Dickson commit c05fa14db43ebef3bd862ca9d073981c0358b3f0 upstream. When vmci_transport_recv_connecting_server() returns an error, vmci_transport_recv_listen() calls vsock_remove_pending() but never calls sk_acceptq_removed(). This leaves sk_ack_backlog incremented permanently. Repeated handshake failures (malformed packets, queue pair alloc failure, event subscribe failure) cause sk_ack_backlog to climb toward sk_max_ack_backlog. Once it reaches the limit the listener permanently refuses all new connections with -ECONNREFUSED, a silent denial of service requiring a process restart to recover. The two existing sk_acceptq_removed() calls in af_vsock.c do not cover this path: line 764 checks vsock_is_pending() which returns false after vsock_remove_pending(), and line 1889 is only reached on successful accept(). Fix by balancing sk_acceptq_added() with sk_acceptq_removed() on the error path. Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Cc: stable@vger.kernel.org Signed-off-by: Raf Dickson Acked-by: Stefano Garzarella Link: https://patch.msgid.link/20260526104356.469928-1-rafdog35@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- net/vmw_vsock/vmci_transport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -974,8 +974,10 @@ static int vmci_transport_recv_listen(st err = -EINVAL; } - if (err < 0) + if (err < 0) { vsock_remove_pending(sk, pending); + sk_acceptq_removed(sk); + } release_sock(pending); vmci_transport_release_pending(pending);