From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81393CEBBD; Tue, 16 Jun 2026 18:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636330; cv=none; b=owMx9fZlS7g22eVIrNj1bU2AarX1fsuwaGYzY8melIdh/kpKeOWTNNH6J83WfRgbV3/zEB8yi/3YGTOBvIR0BVOeVg+ccEPMwCquTJJpwT5mlqGbvGyvFZ2BYSTIWHJKhhFQBIlzM8Hi+9Wc5KEptNe3NDNCMsR5fWiK/Qo1Z0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636330; c=relaxed/simple; bh=cklGEa3jkC1lM5JfUdwO0HjI1joTgZeokO7ip+CcmZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hLvd6NrghK/QyMQkn8i6pSavDJBu4naES2DONKA0WPobDa+DSWmQ3F9O71FYBXO56ZTAuNuw4E8ee7T02490P4hE8lOUdu6NDTMdJevNkzsDpNTBdQVwFmRcxb/9Cp2KTwGEq/UISF3BWWsPnH4w7IyQuZi5V4skr9uK2Eah2zA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AYv9Y96M; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AYv9Y96M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB1D21F000E9; Tue, 16 Jun 2026 18:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636329; bh=SEEnjFf7a3rA5Xfim7wf6WpHrlV8XFMniJi8KcO+Nos=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AYv9Y96MgXlOCnfnJXSAXjrvNKZTLwZLhJsPsEnfGvnHZu6tGYcWCSv/hNu77M1HE LsJauccS3NrCO5iy1jSuZ4wcpzQnFlPYImc7U96kOF6ILb9bzxCAfCG5r7EvKjgdvC hjHnIRWhIkhUrZs3X68xaK+BJMmzJZ1WYuWymp6E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jann Horn , Miklos Szeredi , "Christian Brauner (Amutable)" Subject: [PATCH 5.10 193/342] fuse: reject fuse_notify() pagecache ops on directories Date: Tue, 16 Jun 2026 20:28:09 +0530 Message-ID: <20260616145057.169205780@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jann Horn commit 9c954499d43aefac01c5dfb57a82b13d2dcf4b94 upstream. The operations FUSE_NOTIFY_STORE and FUSE_NOTIFY_RETRIEVE allow the FUSE daemon to actively write/read pagecache contents. For directories with FOPEN_CACHE_DIR, the pagecache is used as kernel-internal cache storage, and userspace is not supposed to have direct access to this cache - in particular, fuse_parse_cache() will hit WARN_ON() if the cache contains bogus data. Reject FUSE_NOTIFY_STORE and FUSE_NOTIFY_RETRIEVE on anything other than regular files with -EINVAL. Fixes: 5d7bc7e8680c ("fuse: allow using readdir cache") Cc: stable@vger.kernel.org Signed-off-by: Jann Horn Link: https://patch.msgid.link/20260519-fuse-dir-pagecache-v2-1-5428fa48e175@google.com Acked-by: Miklos Szeredi Signed-off-by: Christian Brauner (Amutable) Signed-off-by: Greg Kroah-Hartman --- fs/fuse/dev.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1603,6 +1603,10 @@ static int fuse_notify_store(struct fuse inode = fuse_ilookup(fc, nodeid, NULL); if (!inode) goto out_up_killsb; + if (!S_ISREG(inode->i_mode)) { + err = -EINVAL; + goto out_iput; + } mapping = inode->i_mapping; index = outarg.offset >> PAGE_SHIFT; @@ -1774,7 +1778,10 @@ static int fuse_notify_retrieve(struct f inode = fuse_ilookup(fc, nodeid, &fm); if (inode) { - err = fuse_retrieve(fm, inode, &outarg); + if (!S_ISREG(inode->i_mode)) + err = -EINVAL; + else + err = fuse_retrieve(fm, inode, &outarg); iput(inode); } up_read(&fc->killsb);