From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2FA93DA5A8; Tue, 16 Jun 2026 19:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636668; cv=none; b=YmRO+a1QE7TP6hBhH7ZZ2nTg76i4k2Yqpswp7clGPeehbIkWDEWTqTwo2eH+zehctC5zM5UMifwkEp0XqdyObgAkubrpZFcsR4xcseI29HmRq8OGwQJTG7NZczuxzaxnXCvP4SJ2SLicCIP0AzrQH51uyQT+5b+6AnUaakJtl9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636668; c=relaxed/simple; bh=Hr0w8gL1TI5qkz+0GTyGT3hVK+A57bOWJOj4S6L00lg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RCDJbQUWXRHRc06PpHuG8OEvyCOP7++ejHPJWH8MoCAuMcNx9zIhrx0a/UgMY0xNrDoHTgDxz4PWFSQ4bySxYV0kqbRS4ZWu4sxusqSmDVCQ97G/56vr7qm+dR9cQcqiraGGVENx9GZCPHvC+i3fZt7FAlAaH0s+erktE5LWvPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gO0HF1NQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gO0HF1NQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBACF1F00A3A; Tue, 16 Jun 2026 19:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636667; bh=6t4ZomJBS3urc4Xm2wXnRYhRuVGqf0VN4QS/5mh0QQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gO0HF1NQFweMqFjAtpdrPvn6Z0nrMk6V6VaPuJGqcprVL0e5ikEFNe2FJyJXbrmv/ ukjXeBp5WqtetHgRqrvcjWEp3YDt5GOOyAGIUh8y56mnYlUomvU0OJialoFXd73bGM bjBwv19L1x2UtQtWwcYmB5JtHyXO3fTcnM4cFzp4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zilin Guan , Dawei Feng , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 281/342] qed: fix double free in qed_cxt_tables_alloc() Date: Tue, 16 Jun 2026 20:29:37 +0530 Message-ID: <20260616145101.496183301@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dawei Feng [ Upstream commit 2bccfb8476ca5f3548afbd623dc7a6980d4e77de ] If one of the later PF or VF CID bitmap allocations fails, qed_cid_map_alloc() jumps to cid_map_fail and frees the previously allocated CID bitmaps before returning an error. qed_cxt_tables_alloc() then calls qed_cxt_mngr_free(), which invokes qed_cid_map_free() again. Fix this by setting each CID bitmap pointer to NULL after bitmap_free() to avoid double free. The bug was first flagged by an experimental analysis tool we are developing for kernel memory-management bugs while analyzing v6.13-rc1. The tool is still under development and is not yet publicly available. Manual inspection confirms that the bug is still present in v7.1-rc3. Runtime reproduction was not attempted because exercising the failing allocation path requires device-specific setup. Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support") Cc: stable@vger.kernel.org Signed-off-by: Zilin Guan Signed-off-by: Dawei Feng Link: https://patch.msgid.link/20260520070323.2762379-1-dawei.feng@seu.edu.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/ethernet/qlogic/qed/qed_cxt.c +++ b/drivers/net/ethernet/qlogic/qed/qed_cxt.c @@ -1038,11 +1038,13 @@ static void qed_cid_map_free(struct qed_ for (type = 0; type < MAX_CONN_TYPES; type++) { bitmap_free(p_mngr->acquired[type].cid_map); + p_mngr->acquired[type].cid_map = NULL; p_mngr->acquired[type].max_count = 0; p_mngr->acquired[type].start_cid = 0; for (vf = 0; vf < MAX_NUM_VFS; vf++) { bitmap_free(p_mngr->acquired_vf[type][vf].cid_map); + p_mngr->acquired_vf[type][vf].cid_map = NULL; p_mngr->acquired_vf[type][vf].max_count = 0; p_mngr->acquired_vf[type][vf].start_cid = 0; }