From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11B7D3DDDA1; Tue, 16 Jun 2026 19:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636806; cv=none; b=PdAcxuRvuaTomRuaw+IggIZB9ZWkmfEUPyuSjwiR+Ero6+B39HZVEO3mzyrookQhEu1Bs9YSCJW473FSG0GhKvm41eQGWpefEnDMFQOvm5ODk4FCV1KO6FOA1KfnO0zA3PiPIm5jC9093JX1OIr7Eh97YoO4LijHGW/Fc6f6nVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636806; c=relaxed/simple; bh=wUT2j33Pw6L7iXb9P+fqmTydknEBUC46haLj+6Swbo8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t894JAvMQmIaCOisKuj3P0fD1+VnadSfEy/UCJrXbmlwM4dZJ1vxJnsFEHPpPm4Twyha8r14Inu6Ec+flSdIlPyiNALGRx6g+0U133AxOGBQ4x4zakMBDa9vCeCmNHrD4srGAJXdiUFuGDGjlL3E+DsCDYKRoCrLNkCwjZbkfKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Zb4PQW4M; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Zb4PQW4M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14F4B1F000E9; Tue, 16 Jun 2026 19:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636805; bh=hsUFhTvaDNnxrpZun9CpMPah7W5YEldU/7RuS075zXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Zb4PQW4MMAEKLqI/jaGd2mr3TylZnrUxn/u25SPtNzt4JSs0qMnJb6UbShEvWDH5u bWepy/BcGUpqtySPoPTBEIKNQd+s1bQfNBurcXPJtcyJ1gTiM7JVMrP4xgC+wT5Xhh HDLv6Du206k/zhrinw1AkMi8/MkuN6oimg6V6EF0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Ijae Kim , Myeonghun Pak , Sasha Levin Subject: [PATCH 5.10 308/342] serial: altera_jtaguart: handle uart_add_one_port() failures Date: Tue, 16 Jun 2026 20:30:04 +0530 Message-ID: <20260616145102.803571111@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak [ Upstream commit ea66be25f0e934f49d24cd0c5845d13cdba3520b ] altera_jtaguart_probe() maps the register window before registering the UART port, but it ignores failures from uart_add_one_port(). If port registration fails, probe still returns success and the mapping remains live until a later remove path that is not part of probe failure cleanup. Return the uart_add_one_port() error and unmap the register window on that failure path. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 5bcd601049c6 ("serial: Add driver for the Altera JTAG UART") Cc: stable Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/20260512065837.79528-1-mhun512@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/altera_jtaguart.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/altera_jtaguart.c +++ b/drivers/tty/serial/altera_jtaguart.c @@ -423,6 +423,7 @@ static int altera_jtaguart_probe(struct struct resource *res_mem; int i = pdev->id; int irq; + int ret; /* -1 emphasizes that the platform must have one port, no .N suffix */ if (i == -1) @@ -462,7 +463,11 @@ static int altera_jtaguart_probe(struct port->flags = UPF_BOOT_AUTOCONF; port->dev = &pdev->dev; - uart_add_one_port(&altera_jtaguart_driver, port); + ret = uart_add_one_port(&altera_jtaguart_driver, port); + if (ret) { + iounmap(port->membase); + return ret; + } return 0; }