From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844203DE42E; Tue, 16 Jun 2026 19:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636837; cv=none; b=lmr5szjt35ggvPDzGMSy2XeFSdhThj87soG4EfuzPyafD/FelOIWa5+PkqwqCT9N7jtUGBlMhf+nVuxtPpoA30DELseAtNaAATpCmYSjVUaB3JkxEPQc8Ip6l1yzjIefxjcAjS474ItF/77usP8m6ViIEe1ks8qEs8NRe9zdNoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781636837; c=relaxed/simple; bh=oUUuzJ2gRKqf8V8da2fLRq8BYaMCcNA6xwkoL7/P0+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WYSbJ1t7nvSuyy7GO9p5CG5slOcgetz4nXGw8Rf3pUfaSCsDwapw/1HRhDjd62125yR5hBFMsqlarf2qTFiP2SDcX4LmMeAaXcPUDC0ilPXKKNb7CY0N4Mdm2MHqB2h4cq+bsZccu0+lk4LNg1QzDV/waAB75Htb4sJIzA3R0EI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ST26Uhfd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ST26Uhfd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D1471F00A3A; Tue, 16 Jun 2026 19:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781636836; bh=UV8HNbpxV3YZ3Etj5seeNkIIEztXKh19inretdaY+s4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ST26UhfdrrFUCPI1yvWMe/6yeTTTk66CMXRgluAp6GuVzb7iZrb8Ju3GDSyFTsthk QtHyV33ZEfTgBDzzMyWlGxLmw52CrKD6jsqIIj0+WPlYXEN6sPuR3EwCX9WNpNIOFD Z3b7+5ueMcjTufdS/apxTfP/r3AT4QBkcBuASnG0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yin Tirui , Lorenzo Stoakes , "David Hildenbrand (arm)" , Lance Yang , Dev Jain , Baolin Wang , Barry Song , Chen Jun , Kefeng Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Vlastimil Babka , Yang Shi , Zi Yan , Andrew Morton , Sasha Levin Subject: [PATCH 5.10 313/342] mm/huge_memory: update file PMD counter before folio_put() Date: Tue, 16 Jun 2026 20:30:09 +0530 Message-ID: <20260616145103.075128390@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145048.348037099@linuxfoundation.org> References: <20260616145048.348037099@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yin Tirui [ Upstream commit 8d878059924f12c1bc24556a92ec56add74de3c8 ] __split_huge_pmd_locked() updates the file/shmem RSS counter after dropping the PMD mapping's folio reference. If folio_put() drops the last reference, mm_counter_file() can later read freed folio state via folio_test_swapbacked(). Move the counter update before folio_put(). Link: https://lore.kernel.org/20260526101337.1984081-1-yintirui@huawei.com Fixes: fadae2953072 ("thp: use mm_file_counter to determine update which rss counter") Signed-off-by: Yin Tirui Reviewed-by: Lorenzo Stoakes Acked-by: David Hildenbrand (arm) Reviewed-by: Lance Yang Reviewed-by: Dev Jain Cc: Baolin Wang Cc: Barry Song Cc: Chen Jun Cc: Kefeng Wang Cc: Liam R. Howlett Cc: Nico Pache Cc: Ryan Roberts Cc: Vlastimil Babka Cc: Yang Shi Cc: Zi Yan Cc: Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- mm/huge_memory.c | 2 ++ 1 file changed, 2 insertions(+) --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2066,7 +2066,9 @@ static void __split_huge_pmd_locked(stru if (!PageReferenced(page) && pmd_young(old_pmd)) SetPageReferenced(page); page_remove_rmap(page, true); + add_mm_counter(mm, mm_counter_file(page), -HPAGE_PMD_NR); put_page(page); + return; } add_mm_counter(mm, mm_counter_file(page), -HPAGE_PMD_NR); return;