From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC97B43C047; Tue, 16 Jun 2026 15:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622766; cv=none; b=kDoIbAVkj4biTICP7Dg6e9qrTneRTx7CmvglQqQ5POiuZj4t3G+QAWJyleaotrN6oiHe9iuCkYXROmf572fWOY7zKjq7wfZqtbGN9M5rmmXmQ9WEZEZIEenVjYVAOTOveJZyfo+gDOPjKhtC2ICYosGIPe1R+IeFkf1J3aubK/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622766; c=relaxed/simple; bh=5jQuezkvcz0so7c/7i5oEI3KlWGsz9+A6W2SWZsas7Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LMTPCa+WkEE+SG37YRvFsECmSEPV8yMeveV/P4P1wUVMCL/yac6ENZ01QlnipxmK6C1UksWDZVrSMCUZ7GMfwfPyKcyQ58YdF++Q4dEyDv687xJxw+H6wm5L3MDUwIBse9Cii8ECkPWG1shawzmbIHlF1pt4yp/jQJKCohkZlTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=azeyg9uO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="azeyg9uO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F3DD1F00A3A; Tue, 16 Jun 2026 15:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781622765; bh=ktqTLY188hNrghvSKHP1x8DJprhe9J5bRtwImPw647M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=azeyg9uO4kACkwOThsnl6ddjvE1PImOLnX07xu0W5s6BhtE4rb3ZbAuJ8UIxqmpPv TgDfed5IuyWAl2BvOPjwLSh8T2rxSTaggVSJJ2xDRAAAEFTN0kUIKhjZiTdNWDlw5j qda8aPtdxdD4Brr1CY95Ytc4JG6tZrLpy9X0sSGA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Mikulas Patocka , Sasha Levin Subject: [PATCH 7.0 025/378] dm cache policy smq: check allocation under invalidate lock Date: Tue, 16 Jun 2026 20:24:16 +0530 Message-ID: <20260616145111.167062280@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145109.744539446@linuxfoundation.org> References: <20260616145109.744539446@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li [ Upstream commit d3f0a606b9f278ece8a0df626ded9c4044071235 ] commit 2d1f7b65f5de ("dm cache policy smq: fix missing locks in invalidating cache blocks") added mq->lock around the destructive part of smq_invalidate_mapping(), but left the e->allocated check outside the critical section. That leaves a check-then-act race. Two concurrent invalidators can both observe e->allocated as true before either of them takes mq->lock. The first invalidator that acquires the lock removes the entry from the queues and hash table and then calls free_entry(), which clears e->allocated and puts the entry back on the free list. The second invalidator can then acquire mq->lock and continue with the stale result of the unlocked check. This can corrupt the SMQ queues or hash table by deleting an entry that is no longer on those structures. It can also hit the allocation check in free_entry() when the same entry is freed again. Move the allocation check under mq->lock so the predicate and the destructive operations are serialized by the same lock. Fixes: 2d1f7b65f5de ("dm cache policy smq: fix missing locks in invalidating cache blocks") Signed-off-by: Guangshuo Li Signed-off-by: Mikulas Patocka Signed-off-by: Sasha Levin --- drivers/md/dm-cache-policy-smq.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-cache-policy-smq.c b/drivers/md/dm-cache-policy-smq.c index dd77a93fd68d2d..1ae304c2f5737c 100644 --- a/drivers/md/dm-cache-policy-smq.c +++ b/drivers/md/dm-cache-policy-smq.c @@ -1590,18 +1590,22 @@ static int smq_invalidate_mapping(struct dm_cache_policy *p, dm_cblock_t cblock) struct smq_policy *mq = to_smq_policy(p); struct entry *e = get_entry(&mq->cache_alloc, from_cblock(cblock)); unsigned long flags; - - if (!e->allocated) - return -ENODATA; + int r = 0; spin_lock_irqsave(&mq->lock, flags); + if (!e->allocated) { + r = -ENODATA; + goto out; + } // FIXME: what if this block has pending background work? del_queue(mq, e); h_remove(&mq->table, e); free_entry(&mq->cache_alloc, e); + +out: spin_unlock_irqrestore(&mq->lock, flags); - return 0; + return r; } static uint32_t smq_get_hint(struct dm_cache_policy *p, dm_cblock_t cblock) -- 2.53.0