From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4CD13A8FE6; Tue, 16 Jun 2026 15:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622509; cv=none; b=uUdO1nmhf00zZEm2BXyaADM/TxGJE/nToiIQ3vbaqAo92UFaRx9iBhrXmIrqYOjQF/Nj1FzMQ2poXQQJuFnUZiDvI+/pAe/y9E0twMQObFNhRiUFUj3L1Z9u9RunJooZ9fzmnL0bBurASzRZ6RfoDhUXeSk7l6NOMRB3ScZkFtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781622509; c=relaxed/simple; bh=SXQlAsFA+ZuqIREo/2cNHXJ6wHl6jMLy2Jt85WYxktw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jOOS+JqYndRPHl8OWPi6ROI4PYPDdjFnHlvqAbKbOT0rkNjZnmfmJW3QpZQb1pXGCeF+U7nOvc8xGTp+knUBeArDFbkYl6q9i2G7anoo6SjYr7bwHxS1ZecMh5Tn/3I9zVrzF0QWtVJGlA1wijeI3Sr8DtDnFD33mM1JS5DbQ8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bUWxKXTR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bUWxKXTR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66F8E1F000E9; Tue, 16 Jun 2026 15:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781622508; bh=CbpAhb7iLjSOrcgpbQXyUJQ7w4OAPaVbK/axzcF6iH0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bUWxKXTRAGPxHGiIlP3doADM8x0r1YD4ckB7YmNY9Y+kC6SuvBqyRJZlwAPVQ4cFx hnGl7TT8HaSeCr5yieZ3mCGi2P01OKUWzph87HxZyf+IEASMXfWI9O63IgzhSlOc0g 8djGhZZwgxsT9fKes4wu0hxbQ3cfQF43Cx5Mmh0Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jeremy Kerr , Simon Horman , Jakub Kicinski , Li hongliang <1468888505@139.com>, Sasha Levin Subject: [PATCH 6.1 003/522] net: mctp: ensure our nlmsg responses are initialised Date: Tue, 16 Jun 2026 20:22:30 +0530 Message-ID: <20260616145125.507866138@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145125.307082728@linuxfoundation.org> References: <20260616145125.307082728@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeremy Kerr [ Upstream commit a6a9bc544b675d8b5180f2718ec985ad267b5cbf ] Syed Faraz Abrar (@farazsth98) from Zellic, and Pumpkin (@u1f383) from DEVCORE Research Team working with Trend Micro Zero Day Initiative report that a RTM_GETNEIGH will return uninitalised data in the pad bytes of the ndmsg data. Ensure we're initialising the netlink data to zero, in the link, addr and neigh response messages. Fixes: 831119f88781 ("mctp: Add neighbour netlink interface") Fixes: 06d2f4c583a7 ("mctp: Add netlink route management") Fixes: 583be982d934 ("mctp: Add device handling and netlink interface") Signed-off-by: Jeremy Kerr Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260209-dev-mctp-nlmsg-v1-1-f1e30c346a43@codeconstruct.com.au Signed-off-by: Jakub Kicinski Signed-off-by: Li hongliang <1468888505@139.com> Signed-off-by: Sasha Levin --- net/mctp/device.c | 1 + net/mctp/neigh.c | 1 + net/mctp/route.c | 1 + 3 files changed, 3 insertions(+) diff --git a/net/mctp/device.c b/net/mctp/device.c index 85cc5f31f1e7c0..fd368249246dff 100644 --- a/net/mctp/device.c +++ b/net/mctp/device.c @@ -71,6 +71,7 @@ static int mctp_fill_addrinfo(struct sk_buff *skb, return -EMSGSIZE; hdr = nlmsg_data(nlh); + memset(hdr, 0, sizeof(*hdr)); hdr->ifa_family = AF_MCTP; hdr->ifa_prefixlen = 0; hdr->ifa_flags = 0; diff --git a/net/mctp/neigh.c b/net/mctp/neigh.c index 590f642413e4ef..c0151a69d2b7c2 100644 --- a/net/mctp/neigh.c +++ b/net/mctp/neigh.c @@ -218,6 +218,7 @@ static int mctp_fill_neigh(struct sk_buff *skb, u32 portid, u32 seq, int event, return -EMSGSIZE; hdr = nlmsg_data(nlh); + memset(hdr, 0, sizeof(*hdr)); hdr->ndm_family = AF_MCTP; hdr->ndm_ifindex = dev->ifindex; hdr->ndm_state = 0; // TODO other state bits? diff --git a/net/mctp/route.c b/net/mctp/route.c index fdeaf80691e555..c9b0b75422432e 100644 --- a/net/mctp/route.c +++ b/net/mctp/route.c @@ -1331,6 +1331,7 @@ static int mctp_fill_rtinfo(struct sk_buff *skb, struct mctp_route *rt, return -EMSGSIZE; hdr = nlmsg_data(nlh); + memset(hdr, 0, sizeof(*hdr)); hdr->rtm_family = AF_MCTP; /* we use the _len fields as a number of EIDs, rather than -- 2.53.0