From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D9D8472769; Tue, 16 Jun 2026 16:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781628903; cv=none; b=WXN1LxC6xG3AAt2KYcTQdiFRuFp3LeA//LOVuYiivUig1JXdkUJq71Dmm7k7F2CXl5pmAiyNcBWGVGSHJUcr9/c90ioZ4Wk0acjOpaes79rWY9R9ql9vOAc/2nW/G0b3BS9i9s2Y6IrySnpdPkdYbSCAZobmgX4cLwJyaS4V6zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781628903; c=relaxed/simple; bh=F/hway9+p0Vmu9/lfLp0I0rSF489eoAR5oLQbVH9VfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sR0O1kzi1uByaA32LRBSFLVYlT/ivrtyjq0qWvPhYUz/nRmmUSo5Jvhg0C9NP8iqicqtimYdb1jPpdFzfil42hExiQCr/yBHyP/qWaNfWElEaG+7Bc45DhlKLSfp8e4pHq+JWHiD3uHjMw2ZA5BH8dINLvrlErUILy1Awvmtt0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xOhwhP+L; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xOhwhP+L" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 219921F000E9; Tue, 16 Jun 2026 16:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781628902; bh=RR0UchwkYrzMgVI1f9r5IrCwhDFJRmlc6pNdj93OWbo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xOhwhP+L9WleB7fQdfnvTTJxPQAIHQMgPjXMO6L4vTQ+9GBkQGdjNrokJ66uTILsY bMgVYOGEMZpsNCMgH9TMH3V21AvjlxeJ5r8qD9kx6gPD4tEhB33b5nqw5QoD05l2l1 xm22v9G/vDu0XLQ9dPfI8lfQgjybMdmP6/CZLP20= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Zhaoyang Yu <2426767509@qq.com>, Andy Shevchenko Subject: [PATCH 6.6 150/452] tty: serial: pch_uart: add check for dma_alloc_coherent() Date: Tue, 16 Jun 2026 20:26:17 +0530 Message-ID: <20260616145125.582936852@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145117.796205997@linuxfoundation.org> References: <20260616145117.796205997@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhaoyang Yu <2426767509@qq.com> commit 6fe472c1bbbe238e91141f7cabc1226e96a60d43 upstream. Add a check for dma_alloc_coherent() failure to prevent a potential NULL pointer dereference in dma_handle_rx(). Properly release DMA channels and the PCI device reference using a goto ladder if the allocation fails. Fixes: 3c6a483275f4 ("Serial: EG20T: add PCH_UART driver") Cc: stable Signed-off-by: Zhaoyang Yu <2426767509@qq.com> Reviewed-by: Andy Shevchenko Link: https://patch.msgid.link/tencent_E328416B7CFD436F6029F2DF02AD7ED89C08@qq.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/pch_uart.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -694,8 +694,7 @@ static void pch_request_dma(struct uart_ if (!chan) { dev_err(priv->port.dev, "%s:dma_request_channel FAILS(Tx)\n", __func__); - pci_dev_put(dma_dev); - return; + goto err_pci_get; } priv->chan_tx = chan; @@ -709,18 +708,26 @@ static void pch_request_dma(struct uart_ if (!chan) { dev_err(priv->port.dev, "%s:dma_request_channel FAILS(Rx)\n", __func__); - dma_release_channel(priv->chan_tx); - priv->chan_tx = NULL; - pci_dev_put(dma_dev); - return; + goto err_req_tx; } /* Get Consistent memory for DMA */ priv->rx_buf_virt = dma_alloc_coherent(port->dev, port->fifosize, &priv->rx_buf_dma, GFP_KERNEL); + if (!priv->rx_buf_virt) + goto err_req_rx; priv->chan_rx = chan; pci_dev_put(dma_dev); + return; + +err_req_rx: + dma_release_channel(chan); +err_req_tx: + dma_release_channel(priv->chan_tx); + priv->chan_tx = NULL; +err_pci_get: + pci_dev_put(dma_dev); } static void pch_dma_rx_complete(void *arg)