From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36F4A3D669A; Tue, 16 Jun 2026 17:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781632279; cv=none; b=usLpKk0pm4FtNfgqotq/Lxt4wZAsBj7vlSiaBXECtSMJItXVLCXN5Ubx4d/FUrmvYMiguzCryOgGGSPssNviY0KGREA5M1RmQ5rAxIc51vc9+npLUB0c3BarjZMkaG51/qF6OCXqa6DVuod30SYpPWzrMZP/EiC67SQZ7mZFA+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781632279; c=relaxed/simple; bh=Yq0GyMjThH8fyZEp7M0sUv7xDEnyQIQ7H0CN54Kce8I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=urKbNdn+/aDB526a2rtnoJzhGfGKLmnMnoiwDNLpb0KlIY1Wteya6/wn/qteOtGgYn9v2lPDXuEjuOUe6TRcjEFACY+EmO3kD81471Iso/JJsqc1RcnAOlXcVBnT1SjcQQwxojl3CTdwpG8w4relyZinStM43xGDi/3nQRe5ekk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OFrHOkB0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OFrHOkB0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 107A81F000E9; Tue, 16 Jun 2026 17:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781632278; bh=du+LYkAMb3JmJYOikrWDBk56ceWoSEERpvv+tc+GVIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OFrHOkB0XcghEKNjxHbMe/fMR7jkBYBD5gfCYnaakqyoJ8KD4WUL0mM0mbT62fIrW LswChFYXS0EUFY9DMuYYysEt3/5IAZ1wm92BojmDvuAoekHkirFPJk1QfLDlNhxzoY dZLFNM5ZVEPE83n7NAZaDkMQXKktjS7w98wCNcno= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Masahisa Kojima , Johan Hovold , Mark Brown , Sasha Levin Subject: [PATCH 6.1 381/522] spi: syncuacer: fix controller deregistration Date: Tue, 16 Jun 2026 20:28:48 +0530 Message-ID: <20260616145143.600431881@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260616145125.307082728@linuxfoundation.org> References: <20260616145125.307082728@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit 75d849c3452e9611de031db45b3149ba9a99035f ] Make sure to deregister the controller before disabling underlying resources like clocks during driver unbind. Fixes: b0823ee35cf9 ("spi: Add spi driver for Socionext SynQuacer platform") Cc: stable@vger.kernel.org # 5.3 Cc: Masahisa Kojima Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260410081757.503099-21-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-synquacer.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-synquacer.c +++ b/drivers/spi/spi-synquacer.c @@ -719,7 +719,7 @@ static int synquacer_spi_probe(struct pl pm_runtime_set_active(sspi->dev); pm_runtime_enable(sspi->dev); - ret = devm_spi_register_controller(sspi->dev, host); + ret = spi_register_controller(host); if (ret) goto disable_pm; @@ -740,9 +740,15 @@ static void synquacer_spi_remove(struct struct spi_controller *host = platform_get_drvdata(pdev); struct synquacer_spi *sspi = spi_controller_get_devdata(host); + spi_controller_get(host); + + spi_unregister_controller(host); + pm_runtime_disable(sspi->dev); clk_disable_unprepare(sspi->clk); + + spi_controller_put(host); } static int __maybe_unused synquacer_spi_suspend(struct device *dev)