From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03E4ACD98E4 for ; Tue, 16 Jun 2026 16:35:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EF6810EB97; Tue, 16 Jun 2026 16:35:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="BNogqe4N"; dkim-atps=neutral Received: from mail-244107.protonmail.ch (mail-244107.protonmail.ch [109.224.244.107]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8008D10EC83 for ; Tue, 16 Jun 2026 16:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=protonmail; t=1781627738; x=1781886938; bh=P2r8RWkNdoFBCLrjIXLOkZZ8fH3MNFSSDE0O0qYF6ug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=BNogqe4NJSTrXOs4CMdDsbFTEMDm+K6W9ODrr/FMiCgu8IPVCldAUGpNYsM+s7/ol ecj/xutzHQw54+MFvOHyc3HfAkMV2PM97gUUZY6Alkahh0vts+BZKC3yxzXZEdvWBa MgbPy2Wae4urKGibQJcqahhRTPKFsZLwjC47UZ+quN850YZukaVOEYEOK2kTOihmNd +yGTk3kU1gTygDcnV3g4b6tK8xVJHI9DaA5rKzJdtJFslc2plwGQxI8XBz8Is0ysyO RJcBjahrNHh2HxZGLqHmmhovyZJl5Ezurk9YFbRJBedyqthKpt1HBC+SSfieK70gz4 AFI8iISJLDpIw== X-Pm-Submission-Id: 4gfszk6rs8z2ScsV From: =?UTF-8?q?Onur=20=C3=96zkan?= To: Danilo Krummrich Cc: Philipp Stanner , Philipp Stanner , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Daniel Almeida , Greg Kroah-Hartman , Igor Korotin , Lorenzo Stoakes , Alexandre Courbot , FUJITA Tomonori , Krishna Ketan Rai , Shankari Anand , manos@pitsidianak.is, Boris Brezillon , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, rcu@vger.kernel.org Subject: Re: [PATCH v2 5/6] rust: Add dma_fence abstractions Date: Tue, 16 Jun 2026 19:35:26 +0300 Message-ID: <20260616163529.6880-1-work@onurozkan.dev> X-Mailer: git-send-email 2.51.2 In-Reply-To: References: <20260616082819.2943886-2-phasta@kernel.org> <20260616082819.2943886-7-phasta@kernel.org> <20260616124755.460550-1-work@onurozkan.dev> <20260616145112.14201-1-work@onurozkan.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 16 Jun 2026 17:28:04 +0200=0D Danilo Krummrich wrote:=0D =0D > On Tue Jun 16, 2026 at 4:51 PM CEST, Onur =C3=96zkan wrote:=0D > > repr(C) only makes sense when the type have multiple fields.=0D > =0D > I don't think that's universally true. repr(transparent) guarantees the l= ayout=0D > and ABI match the inner field. The wrapper is passed through calls exactl= y as=0D > the field would be. repr(C) guarantees C-compatible layout and makes the = type=0D > follow the platform's C ABI for passing an aggregate, which isn't always = how the=0D > bare field is passed.=0D =0D I was too focused on the field ordering perspective during the review, sorr= y for=0D that.=0D =0D Onur=0D