From: linuxtestproject.agent@gmail.com
To: Michael Menasherov <mmenashe@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] futex_wake05: Add EFAULT error coverage test
Date: Tue, 16 Jun 2026 19:47:19 +0000 [thread overview]
Message-ID: <20260616194719.4126-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260616183025.26554-2-mmenashe@redhat.com>
Hi Michael,
On Tue, 16 Jun 2026, Michael Menasherov wrote:
> futex_cmp_requeue03: Add EFAULT error coverage test
--- [PATCH 2/2] ---
> futex(FUTEX_CMP_REQUEUE) has no existing test for EFAULT. Add coverage
> for the cases where uaddr or uaddr2 points to unmapped or inaccessible
> (PROT_NONE) memory.
The commit message says "uaddr or uaddr2 points to ... inaccessible
(PROT_NONE) memory", but the test only covers uaddr with PROT_NONE.
There is no "uaddr2 PROT_NONE" test case. Since get_futex_key() is
called independently for uaddr2, it would be consistent to add
coverage for that case too, or alternatively narrow the commit
message to match what is actually tested.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-16 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 18:30 [LTP] [PATCH v15 0/2] futex: Add EFAULT coverage for wake and cmp_requeue Michael Menasherov via ltp
2026-06-16 18:30 ` [LTP] [PATCH v15 1/2] futex_wake05: Add EFAULT error coverage test Michael Menasherov via ltp
2026-06-16 19:47 ` linuxtestproject.agent [this message]
2026-06-17 12:07 ` Andrea Cervesato via ltp
2026-06-17 13:07 ` Cyril Hrubis
2026-06-16 18:30 ` [LTP] [PATCH v15 2/2] futex_cmp_requeue03: " Michael Menasherov via ltp
2026-06-17 12:34 ` Andrea Cervesato via ltp
-- strict thread matches above, loose matches on Subject: below --
2026-06-21 15:09 [LTP] [PATCH v16 1/2] futex_wake05: " Michael Menasherov via ltp
2026-06-22 9:44 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616194719.4126-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=mmenashe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.