[mptcp:export 6/37] drivers/net/ethernet/microsoft/mana/mana_en.c:2406:4: warning: misleading indentation; statement is not part of the previous 'if'

[kernel test robot <lkp@intel.com>]

tree:   https://github.com/multipath-tcp/mptcp_net-next.git export
head:   f539e897493cd0b5c3745ec4b33a2690afc7c7de
commit: 508cdf985e09fe14eb5e1da1d2e2a124b2cbae23 [6/37] TopGit-driven merge of branches:
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20260616/202606162155.rSSbzs8P-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project e19d1f51a2c80b63cd8ca95bcc757b7077112808)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260616/202606162155.rSSbzs8P-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606162155.rSSbzs8P-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/microsoft/mana/mana_en.c:2405:51: error: member reference type 'struct mana_tx_qp *' is a pointer; did you mean to use '->'?
    2405 |                         mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i].tx_object);
         |                                                           ~~~~~~~~~~~~~^
         |                                                                        ->
>> drivers/net/ethernet/microsoft/mana/mana_en.c:2406:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
    2406 |                         mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i]->tx_object);
         |                         ^
   drivers/net/ethernet/microsoft/mana/mana_en.c:2404:3: note: previous statement is here
    2404 |                 if (apc->tx_qp[i]->tx_object != INVALID_MANA_HANDLE)
         |                 ^
   1 warning and 1 error generated.


vim +/if +2406 drivers/net/ethernet/microsoft/mana/mana_en.c

ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2381  
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2382  static void mana_destroy_txq(struct mana_port_context *apc)
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2383  {
e1b5683ff62e7b Haiyang Zhang          2021-08-24  2384  	struct napi_struct *napi;
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2385  	int i;
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2386  
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2387  	if (!apc->tx_qp)
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2388  		return;
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2389  
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2390  	for (i = 0; i < apc->num_queues; i++) {
d07efe5a6e641a Aditya Garg            2026-05-02  2391  		if (!apc->tx_qp[i])
d07efe5a6e641a Aditya Garg            2026-05-02  2392  			continue;
d07efe5a6e641a Aditya Garg            2026-05-02  2393  
d07efe5a6e641a Aditya Garg            2026-05-02  2394  		debugfs_remove_recursive(apc->tx_qp[i]->mana_tx_debugfs);
d07efe5a6e641a Aditya Garg            2026-05-02  2395  		apc->tx_qp[i]->mana_tx_debugfs = NULL;
6607c17c6c5e02 Shradha Gupta          2024-10-08  2396  
d07efe5a6e641a Aditya Garg            2026-05-02  2397  		napi = &apc->tx_qp[i]->tx_cq.napi;
d07efe5a6e641a Aditya Garg            2026-05-02  2398  		if (apc->tx_qp[i]->txq.napi_initialized) {
e1b5683ff62e7b Haiyang Zhang          2021-08-24  2399  			napi_synchronize(napi);
d5c8f0e4e0cb0a Erni Sri Satya Vennela 2025-06-17  2400  			napi_disable_locked(napi);
d5c8f0e4e0cb0a Erni Sri Satya Vennela 2025-06-17  2401  			netif_napi_del_locked(napi);
d07efe5a6e641a Aditya Garg            2026-05-02  2402  			apc->tx_qp[i]->txq.napi_initialized = false;
b6ecc662037694 Souradeep Chakrabarti  2024-09-02  2403  		}
508cdf985e09fe Matthieu Baerts (NGI0  2026-06-15  2404) 		if (apc->tx_qp[i]->tx_object != INVALID_MANA_HANDLE)
ca9c54d2d6a5ab Dexuan Cui             2021-04-16 @2405  			mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i].tx_object);
d07efe5a6e641a Aditya Garg            2026-05-02 @2406  			mana_destroy_wq_obj(apc, GDMA_SQ, apc->tx_qp[i]->tx_object);
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2407  
d07efe5a6e641a Aditya Garg            2026-05-02  2408  		mana_deinit_cq(apc, &apc->tx_qp[i]->tx_cq);
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2409  
d07efe5a6e641a Aditya Garg            2026-05-02  2410  		mana_deinit_txq(apc, &apc->tx_qp[i]->txq);
d07efe5a6e641a Aditya Garg            2026-05-02  2411  
d07efe5a6e641a Aditya Garg            2026-05-02  2412  		kvfree(apc->tx_qp[i]);
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2413  	}
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2414  
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2415  	kfree(apc->tx_qp);
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2416  	apc->tx_qp = NULL;
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2417  }
ca9c54d2d6a5ab Dexuan Cui             2021-04-16  2418  

:::::: The code at line 2406 was first introduced by commit
:::::: d07efe5a6e641af59f2dbbef4a748fab6d967747 net: mana: Use per-queue allocation for tx_qp to reduce allocation size

:::::: TO: Aditya Garg <gargaditya@linux.microsoft.com>
:::::: CC: Jakub Kicinski <kuba@kernel.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki