From: Michal Pecio <michal.pecio@gmail.com>
To: Amin Vakil <info@aminvakil.com>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Tao Xue <xuetao09@huawei.com>,
regressions@lists.linux.dev
Subject: Re: [REGRESSION] usb: core: interrupt-IN wBytesPerInterval fixup (727d045d064b) breaks RTL8153 in Lenovo dock
Date: Tue, 16 Jun 2026 23:20:27 +0200 [thread overview]
Message-ID: <20260616232027.10ba0415.michal.pecio@gmail.com> (raw)
In-Reply-To: <8f862eb6-adfb-43a9-b4f5-8f9232333b51@aminvakil.com>
On Tue, 16 Jun 2026 20:22:19 +0330, Amin Vakil wrote:
> On 6/16/26 8:06 PM, Michal Pecio wrote:
> > RTL8153 was one of the chips specifically targeted by this fix, but
> > it affects the CDC configuration which you don't seem to be using.
> >
> > I have tried linux-hardened-7.0.12.hardened1-1-x86_64 from Arch repo
> > as well as my own build of 7.1-rc6, and my RTL8153 (0bda:8153) in a
> > different kind of USB-C dock still works with a few xHCI controllers.
> >
> > So it's some weird problem narrowly specific to your system. Now that
> > you have built your own kernel, please also revert the suspect patch
> > to verify if that's really it.
>
> Honestly I've tried patching it myself :)
>
> by changing
>
> (le16_to_cpu(desc->wBytesPerInterval) < usb_endpoint_maxp(&ep->desc) &&
>
> to
>
> (le16_to_cpu(desc->wBytesPerInterval) == 0 &&
>
> in line 187 of drivers/usb/core/config.c to see if that fixes the issue
> and it did not, but I didn't specifically reverted the commit to see if
> that fixes the issue.
This should be enough to prevent overriding wBytesPerInterval on
RTL8153 (and get rid of the new log message).
If the message goes away but the device still doesn't work, the problem
must be somewhere else.
I would start with userspace - if you haven't already, downgrade to
some kernel package which worked in the past. See if it still works.
Or check if 9ddb9c0deca48d2c2a22ebf4d2f35c925a520328 applies to your
dock and try reverting it if it does.
Otherwise, no idea, besides git-bisect I guess.
Regards,
Michal
prev parent reply other threads:[~2026-06-16 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 9:49 [REGRESSION] usb: core: interrupt-IN wBytesPerInterval fixup (727d045d064b) breaks RTL8153 in Lenovo dock Amin Vakil
2026-06-16 10:28 ` Thorsten Leemhuis
2026-06-16 11:51 ` Amin Vakil
2026-06-16 14:08 ` Amin Vakil
2026-06-16 16:36 ` Michal Pecio
2026-06-16 16:52 ` Amin Vakil
2026-06-16 21:20 ` Michal Pecio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260616232027.10ba0415.michal.pecio@gmail.com \
--to=michal.pecio@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@aminvakil.com \
--cc=linux-usb@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stern@rowland.harvard.edu \
--cc=xuetao09@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.