From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AB9829E0F6; Tue, 16 Jun 2026 07:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781596262; cv=none; b=pAts1B7+cZPpl4MDcCHQ4u0pLPKRoKtkZyoGOxLQLaPYmwqmHA7ZKPoyJi8ZXHRXzd9mRWNAcSm2PCedxDaB+5fJi+g4/+MkJ2lTQWSVDOGabeVwKHs9avb2Tn/jsWy8M2zeirNp4ehxPivE2Ymh5eDPVrbDpdE7fVslb8Lj55g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781596262; c=relaxed/simple; bh=uJxWpeOfEAepMDUMTOO/Epb81Yyg+ycB2o8WluOl3ak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s8lD//iohaR78humNiN/nAealpQthnzXUen1rNF+miOEj3s5LNWJuVtcRtjuGeU8eX7zhdrmNso401yJLiMq060xeRTlY95elrzWTjYysT0QGTuoaQVhKmgoqZ4IEulQgKKLjN3D0iQJro5XbiBB3yeTnfifHtdIq5dYQICnavI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gmIYG5wY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gmIYG5wY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47BE41F000E9; Tue, 16 Jun 2026 07:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1781596261; bh=pwdFybGyEInzWGubnBHN0JGC/ZK8oGwddFQqTa3vWnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gmIYG5wY8E5j0BrQ9WMPwTbfxv6G/t1PzVSaGpFslrW/Dpqm/47Os2Ri3TidK4okB plefFtf8zIgXYEihxDsWdHlajRh/su+hMCLCun8uFal7P1QJHdHV1rS6ESQ6THvi9Q IsItZGRmaMzP6BkTBFYjcCATEahbWLuYgfrxfaLs= Date: Tue, 16 Jun 2026 13:19:56 +0530 From: Greg KH To: "enlin.mu" Cc: tglx@kernel.org, linux-kernel@vger.kernel.org, enlin.mu@unisoc.com, linux-hardening@vger.kernel.org Subject: Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler Message-ID: <2026061636-boxlike-trimmer-13ca@gregkh> References: <20260616055042.3923-1-enlin.mu@linux.dev> <2026061620-unselfish-barber-c467@gregkh> <476066de-b7e0-4400-a9e1-17b045defa80@linux.dev> <2026061658-unable-rarity-3253@gregkh> <1ec9d261-1f42-4553-8a09-0ba40c93f786@linux.dev> <2026061633-preseason-framing-7acc@gregkh> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 16, 2026 at 03:40:10PM +0800, enlin.mu wrote: > > > On 2026/6/16 15:24, Greg KH wrote: > > On Tue, Jun 16, 2026 at 03:17:00PM +0800, enlin.mu wrote: > > > > > > > > > On 2026/6/16 14:48, Greg KH wrote: > > > > A: http://en.wikipedia.org/wiki/Top_post > > > > Q: Were do I find info about this thing called top-posting? > > > > A: Because it messes up the order in which people normally read text. > > > > Q: Why is top-posting such a bad thing? > > > > A: Top-posting. > > > > Q: What is the most annoying thing in e-mail? > > > > > > > > A: No. > > > > Q: Should I include quotations after my reply? > > > > > > > > http://daringfireball.net/2007/07/on_top > > > > > > > > On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote: > > > > > Hi KH > > > > > > > > > > hardware: raspberrypi 5 > > > > > > > > > > other patch(These two locations impact the entropy pool acceleration. > > > > > comment them out temporarily): > > > > > acer@raspberrypi:linux $ git diff drivers/of/fdt.c > > > > > drivers/char/hw_random/iproc-rng200.c > > > > > diff --git a/drivers/char/hw_random/iproc-rng200.c > > > > > b/drivers/char/hw_random/iproc-rng200.c > > > > > index 33bc28f429f6..af105faa88c6 100644 > > > > > --- a/drivers/char/hw_random/iproc-rng200.c > > > > > +++ b/drivers/char/hw_random/iproc-rng200.c > > > > > @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = { > > > > > }; > > > > > > > > > > static const struct of_device_id iproc_rng200_of_match[] = { > > > > > - { .compatible = "brcm,bcm2711-rng200", }, > > > > > - { .compatible = "brcm,bcm7211-rng200", }, > > > > > - { .compatible = "brcm,bcm7278-rng200", }, > > > > > - { .compatible = "brcm,iproc-rng200", }, > > > > > + { .compatible = "brcm,bcm2711-rng2000", }, > > > > > + { .compatible = "brcm,bcm7211-rng2000", }, > > > > > + { .compatible = "brcm,bcm7278-rng2000", }, > > > > > + { .compatible = "brcm,iproc-rng2000", }, > > > > > > > > What is this change for? > > > This driver accelerates the initialization of the entropy pool. If this > > > dirver is added, the optimization effect of my patch will no longer be > > > clearly observable. > > > > Great, obviously your patch is not needed! > > > > > > > > > > > > > > > > > > {}, > > > > > }; > > > > > MODULE_DEVICE_TABLE(of, iproc_rng200_of_match); > > > > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > > > > > index 331646d667b9..13308d58785d 100644 > > > > > --- a/drivers/of/fdt.c > > > > > +++ b/drivers/of/fdt.c > > > > > @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline) > > > > > > > > > > rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l); > > > > > if (rng_seed && l > 0) { > > > > > - add_bootloader_randomness(rng_seed, l); > > > > > + //add_bootloader_randomness(rng_seed, l); > > > > > > > > Why did you comment this out? > > > Before the kernel boots, the Raspberry Pi bootloader injects the rng-seed > > > property into the kernel's Device Tree to accelerate entropy pool > > > initialization. Therefore, I need to temporarily comment this out > > > to avoid interfering with the testing of my current patch. > > > > Again, that seems like the correct fix, don't change the common code > > path of all systems just because you don't want to accept the changes > > that have already been made for your platform to resolve this very > > issue! > > I think there might be a misunderstanding. The code below adds entropy pool > initialization, but this logic is missing in the PPI interrupt handler. I > believe this was simply an accidental omission. > --------------------------- > irqreturn_t handle_irq_event_percpu(struct irq_desc *desc) > { > irqreturn_t retval; > > retval = __handle_irq_event_percpu(desc); > > add_interrupt_randomness(desc->irq_data.irq); > > if (!irq_settings_no_debug(desc)) > note_interrupt(desc, retval); > return retval; Look back at your original patch. It contained none of this information...