From: Greg KH <greg@kroah.com>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org,
Rodrigo Alencar <rodrigo.alencar@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 6.6.y] iio: dac: ad5686: fix powerdown control on dual-channel devices
Date: Tue, 16 Jun 2026 10:35:45 +0530 [thread overview]
Message-ID: <2026061638-struggle-enforced-f8d7@gregkh> (raw)
In-Reply-To: <20260604161903.3777464-1-sashal@kernel.org>
On Thu, Jun 04, 2026 at 12:19:03PM -0400, Sasha Levin wrote:
> From: Rodrigo Alencar <rodrigo.alencar@analog.com>
>
> [ Upstream commit 8aeaf25a85263a7a43357e16ad78ab969f6f8aeb ]
>
> Fix powerdown control by using a proper bit shift for the powerdown mask
> values. During initialization, powerdown bits are initialized so that
> unused bits are set to 1 and the correct bit shift is used. Dual-channel
> devices use one-hot encoding in the address and that reflects on the
> position of the powerdown bits, which are not channel-index based
> for that case. Quad-channel devices also use one-hot encoding for the
> channel address but the result of log2(address) coincides with the channel
> index value. Mask as 0x3U is used rather than 0x3, because shift can reach
> value of 30 (last channel of a 16-channel device), which would mess with
> the sign bit. The issue was introduced when first adding support for
> dual-channel devices, which overlooked powerdown control differences.
>
> Fixes: 7dc8faeab3e3 ("iio: dac: ad5686: add support for AD5338R")
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> Cc: <Stable@vger.kernel.org>
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> drivers/iio/dac/ad5686.c | 46 +++++++++++++++++++++++++++++++---------
> 1 file changed, 36 insertions(+), 10 deletions(-)
>
Does not apply :(
prev parent reply other threads:[~2026-06-16 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 8:44 FAILED: patch "[PATCH] iio: dac: ad5686: fix powerdown control on dual-channel" failed to apply to 6.6-stable tree gregkh
2026-06-04 16:19 ` [PATCH 6.6.y] iio: dac: ad5686: fix powerdown control on dual-channel devices Sasha Levin
2026-06-16 5:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026061638-struggle-enforced-f8d7@gregkh \
--to=greg@kroah.com \
--cc=jic23@kernel.org \
--cc=rodrigo.alencar@analog.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.