From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vladislav Nikolaev <vlad102nikolaev@gmail.com>
Cc: stable@vger.kernel.org, Zhu Yanjun <zyjzyj2000@gmail.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Haggai Eran <haggaie@mellanox.com>,
Kamal Heib <kamalh@mellanox.com>, Amir Vadai <amirv@mellanox.com>,
Moni Shoua <monis@mellanox.com>,
Yonatan Cohen <yonatanc@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhu Yanjun <yanjunz@nvidia.com>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH 6.1 1/3] Revert "RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task""
Date: Tue, 16 Jun 2026 19:09:06 +0530 [thread overview]
Message-ID: <2026061651-affected-ream-c0b3@gregkh> (raw)
In-Reply-To: <20260605170349.1524-2-vlad102nikolaev@gmail.com>
On Fri, Jun 05, 2026 at 08:03:27PM +0300, Vladislav Nikolaev wrote:
> This reverts commit 3236221bb8e4de8e3d0c8385f634064fb26b8e38.
>
> The reverted commit is an incomplete backport of upstream
> commit b2b1ddc45745. It added guards for req.task and comp.task
> cleanup, but missed resp.task cleanup and left it before the RC timer
> cleanup, unlike the upstream fix. Revert it first so the correct
> backport can be applied cleanly in the following patch.
>
> Signed-off-by: Vladislav Nikolaev <vlad102nikolaev@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe_qp.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
> index 709c63e9773c..05e4a270084f 100644
> --- a/drivers/infiniband/sw/rxe/rxe_qp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_qp.c
> @@ -788,11 +788,8 @@ static void rxe_qp_do_cleanup(struct work_struct *work)
> del_timer_sync(&qp->rnr_nak_timer);
> }
>
> - if (qp->req.task.func)
> - rxe_cleanup_task(&qp->req.task);
> -
> - if (qp->comp.task.func)
> - rxe_cleanup_task(&qp->comp.task);
> + rxe_cleanup_task(&qp->req.task);
> + rxe_cleanup_task(&qp->comp.task);
>
> /* flush out any receive wr's or pending requests */
> if (qp->req.task.func)
> --
> 2.43.0
>
This series does not apply to the latest tree :(
Are you sure it is still needed?
thanks,
greg k-h
next prev parent reply other threads:[~2026-06-16 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 17:03 [PATCH 6.1 0/3] RDMA/rxe: correct cleanup-task backport and timer cleanup Vladislav Nikolaev
2026-06-05 17:03 ` [PATCH 6.1 1/3] Revert "RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task"" Vladislav Nikolaev
2026-06-16 13:39 ` Greg Kroah-Hartman [this message]
2026-06-05 17:03 ` [PATCH 6.1 2/3] RDMA/rxe: Fix the error "trying to register non-static key in rxe_cleanup_task" Vladislav Nikolaev
2026-06-05 17:03 ` [PATCH 6.1 3/3] RDMA/rxe: Fix "trying to register non-static key in rxe_qp_do_cleanup" bug Vladislav Nikolaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026061651-affected-ream-c0b3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=amirv@mellanox.com \
--cc=dledford@redhat.com \
--cc=haggaie@mellanox.com \
--cc=jgg@ziepe.ca \
--cc=kamalh@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=monis@mellanox.com \
--cc=stable@vger.kernel.org \
--cc=vlad102nikolaev@gmail.com \
--cc=yanjunz@nvidia.com \
--cc=yonatanc@mellanox.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.