Re: [PATCH 4/5] dt-bindings: arm: mediatek: Add MT8127 Amazon ford

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree compatible block for `amazon,ford` is incorrectly sorted. The file specifies that entries should be sorted by SoC compatible and then alphabetically by board compatible. Because `amazon,ford` and `mediatek,mt8127-moose` share the same SoC compatible (`mediatek,mt8127`), `amazon,ford` should be placed before `mediatek,mt8127-moose`.
--

commit 5d4dd6329b44b144dcfbe78c4a1cf82524b51ef6
Author: Zakariya Hadrami <zkh1@proton.me>

dt-bindings: arm: mediatek: Add MT8127 Amazon ford

This commit adds the device tree binding for the Amazon ford tablet based
on the MediaTek MT8127 SoC.

> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 382d0eb4d0af6..5ddc79689df91 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -124,6 +124,10 @@ properties:
>            - enum:
>                - mediatek,mt8127-moose
>            - const: mediatek,mt8127
> +      - items:
> +          - enum:
> +              - amazon,ford
> +          - const: mediatek,mt8127

[Severity: Low]
This isn't a bug, but should the amazon,ford board compatible block be
inserted alphabetically before mediatek,mt8127-moose? Since both share the
mediatek,mt8127 SoC compatible, sorting alphabetically by the board
compatible would usually place amazon,ford first.

>        - items:
>            - enum:
>                - mediatek,mt8135-evbp1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260617-mt8127-amazon-ford-basic-v1-0-d02ad15ac359@proton.me?part=4