From: sashiko-bot@kernel.org
To: joakim.zhang@cixtech.com
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 3/5] dt-bindings: clock: cix,sky1-audss-clock: add audss clock controller
Date: Wed, 17 Jun 2026 06:08:32 +0000 [thread overview]
Message-ID: <20260617060833.2D4DA1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260617060437.1474816-4-joakim.zhang@cixtech.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the clocks property description: 'delicated' instead of 'dedicated'.
--
commit 0bf88f97ab11d2c8010b886d37df1eed62b3d256
Author: Joakim Zhang <joakim.zhang@cixtech.com>
dt-bindings: clock: cix,sky1-audss-clock: add audss clock controller
This commit adds a devicetree binding for the Cix Sky1 audio subsystem
(AUDSS) clock controller. It acts as a child of the system control
syscon, routing 4 reference clocks to internal consumers.
> diff --git a/Documentation/devicetree/bindings/clock/cix,sky1-audss-clock.yaml b/Documentation/devicetree/bindings/clock/cix,sky1-audss-clock.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/cix,sky1-audss-clock.yaml
[ ... ]
> + clocks:
> + items:
> + - description: I2S parent clock for sampling rates multiple of 8kHz.
> + - description: I2S parent clock for sampling rates multiple of 11.025kHz.
> + - description: clock feeding most devices in audss (NOC, DSP, SRAM, HDA, DMAC, I2S, and Mailbox).
> + - description: clock feeding for HDA, Timer and Watchdog, which is a delicated 48MHz clock.
[Severity: Low]
This isn't a bug, but there is a typo here where delicated is used instead of
dedicated.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260617060437.1474816-1-joakim.zhang@cixtech.com?part=3
next prev parent reply other threads:[~2026-06-17 6:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 6:04 [PATCH v4 0/5] Add Cix Sky1 AUDSS clock and reset support joakim.zhang
2026-06-17 6:04 ` [PATCH v4 1/5] dt-bindings: soc: cix,sky1-system-control: add audss system control joakim.zhang
2026-06-17 6:10 ` sashiko-bot
2026-06-17 6:04 ` [PATCH v4 2/5] reset: cix: add audss support to sky1 reset driver joakim.zhang
2026-06-17 6:12 ` sashiko-bot
2026-06-17 6:04 ` [PATCH v4 3/5] dt-bindings: clock: cix,sky1-audss-clock: add audss clock controller joakim.zhang
2026-06-17 6:08 ` sashiko-bot [this message]
2026-06-17 6:04 ` [PATCH v4 4/5] clk: cix: add sky1 " joakim.zhang
2026-06-17 6:16 ` sashiko-bot
2026-06-17 6:04 ` [PATCH v4 5/5] arm64: dts: cix: sky1: add audss system control joakim.zhang
2026-06-17 6:38 ` [PATCH v4 0/5] Add Cix Sky1 AUDSS clock and reset support Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617060833.2D4DA1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joakim.zhang@cixtech.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.