From: Bin Guo <guobin@linux.alibaba.com>
To: peterx@redhat.com
Cc: qemu-devel@nongnu.org, farosas@suse.de, lizhijian@fujitsu.com
Subject: Re: [PATCH 1/2] migration/rdma: honor blocking mode in QIOChannelRDMA readv
Date: Wed, 17 Jun 2026 14:36:45 +0800 [thread overview]
Message-ID: <20260617063645.69850-1-guobin@linux.alibaba.com> (raw)
In-Reply-To: <20260529070408.92651-2-guobin@linux.alibaba.com>
On Tue, 16 Jun 2026, Peter Xu wrote:
> this patch made it the other way round: the channel didn't respect
> blocking mode because it always blocks, not always non-block.
You're right, the commit message was misleading.
The function already blocks inside qemu_rdma_exchange_recv() when
waiting for the next RDMA SEND message. What it didn't do was keep
blocking when the bytes from a *single* receive were not enough to
satisfy the full request -- it would return partial data instead of
waiting for more.
In blocking mode a QIOChannel readv should keep trying until the
request is satisfied (or an error occurs), matching the behaviour of
other QIOChannel implementations. That's what the loop is for.
> Also, this is only the read path; there's also write.
The write path already loops over the full iov in
qio_channel_rdma_writev(), so it handles the blocking case
correctly. Only read needed fixing.
I'll send a v2 with a corrected commit message. Thanks for the
review.
Bin Guo
next prev parent reply other threads:[~2026-06-17 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 7:04 [PATCH 0/2] migration/rdma: fix blocking readv and zero-page accounting Bin Guo
2026-05-29 7:04 ` [PATCH 1/2] migration/rdma: honor blocking mode in QIOChannelRDMA readv Bin Guo
2026-06-16 19:09 ` Peter Xu
2026-06-17 6:36 ` Bin Guo [this message]
2026-06-17 7:27 ` laiqi.gb via qemu development
2026-05-29 7:04 ` [PATCH 2/2] migration/rdma: account transferred bytes for zero page compression Bin Guo
2026-06-08 1:51 ` [PATCH 0/2] migration/rdma: fix blocking readv and zero-page accounting Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617063645.69850-1-guobin@linux.alibaba.com \
--to=guobin@linux.alibaba.com \
--cc=farosas@suse.de \
--cc=lizhijian@fujitsu.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.