Re: [PATCH] Support new NV140FHM-N5B and TM156VDXP25 edp panel, the NV140FHM-N5B need 200ms delays from the backlight to valid data, 100ms delays from backlight off to valid data, the TM156VDXP25 need 100ms delays from the backlight to valid data.

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatch between stated panel delay requirements in the commit message and the assigned delay struct.
--

commit a20ff596ba1f763a527dc4fb43598b1e0368d9e8
Author: Haikun Zhou <zhouhaikun5@huaqin.corp-partner.google.com>

Support new NV140FHM-N5B and TM156VDXP25 edp panel, the NV140FHM-N5B need 200ms delays from the backlight to valid data, 100ms delays from backlight off to valid data, the TM156VDXP25 need 100ms delays from the backlight to valid data.

This commit adds support for the NV140FHM-N5B and TM156VDXP25 eDP panels.
It introduces their respective EDID data and defines delay timings required
for their operations.

> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index aa27d6cd932e8..afbeaddca4b9a 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c

[ ... ]

> @@ -2151,6 +2161,7 @@ static const struct edp_panel_entry edp_panels[] = {
>  
>  	EDP_PANEL_ENTRY('T', 'M', 'A', 0x0811, &delay_200_500_e80_d50, "TM140VDXP01-04"),
>  	EDP_PANEL_ENTRY('T', 'M', 'A', 0x2094, &delay_200_500_e50_d100, "TL140VDMS03-01"),
> +	EDP_PANEL_ENTRY('T', 'M', 'A', 0x2139, &delay_200_500_e50_d100, "TM156VDXP25"),

[Severity: Medium]
The commit message states that the TM156VDXP25 panel requires "100ms delays
from the backlight to valid data". Based on the description for the
NV140FHM-N5B panel in the same commit message, this terminology maps to
setting .powered_on_to_enable.

However, the assigned delay struct here (delay_200_500_e50_d100) sets
.disable = 100 and does not set .powered_on_to_enable = 100.

Does the commit message have a typo and intended to say "100ms delays from
backlight off to valid data", or should this panel be assigned a different
delay structure that sets .powered_on_to_enable = 100?

>  
>  	{ /* sentinal */ }
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260617100120.3426673-1-zhouhaikun5@huaqin.corp-partner.google.com?part=1