Re: [PATCH v5 3/7] bootconfig: render embedded bootconfig as a kernel cmdline at build time

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unquoted `CC=$(HOSTCC)` in the top-level Makefile breaks the build when `HOSTCC` contains spaces (e.g., `HOSTCC="ccache gcc"`).
--

commit 9679f5db7f804f330ff90fdcd19d5b8a66732ef3
Author: Breno Leitao <leitao@debian.org>

bootconfig: render embedded bootconfig as a kernel cmdline at build time

This commit adds a build-time pipeline that renders the "kernel" subtree of
CONFIG_BOOT_CONFIG_EMBED_FILE into a flat cmdline string. It wires up
tools/bootconfig in the Makefile's prepare target to generate the
embedded_kernel_cmdline array.

> diff --git a/Makefile b/Makefile
> index 7a9385dab39ab..6cb2bec7bfe78 100644
> --- a/Makefile
> +++ b/Makefile

[ ... ]

> @@ -1549,6 +1549,21 @@ prepare: tools/bpf/resolve_btfids
>  endif
>  endif
>  
> +# tools/bootconfig renders the embedded bootconfig into a cmdline at build time.
> +ifdef CONFIG_BOOT_CONFIG_EMBED_CMDLINE
> +prepare: tools/bootconfig
> +endif
> +
> +# tools/bootconfig is run on the build host during prepare, so force a host
> +# binary here; its own Makefile keeps $(CC) for standalone and cross builds.
> +# CROSS_COMPILE= is cleared so tools/scripts/Makefile.include does not inject
> +# the target's --target=/--sysroot= flags into the host clang invocation under
> +# LLVM=1 cross builds (which would produce a target binary that fails to exec).
> +tools/bootconfig: FORCE
> +	$(Q)mkdir -p $(objtree)/tools
> +	$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ \
> +		bootconfig CC=$(HOSTCC) CROSS_COMPILE=

[Severity: Low]
Will this break the build if HOSTCC contains spaces, such as when using a
compiler cache wrapper like HOSTCC="ccache gcc"?

If $(HOSTCC) is unquoted, Make might interpret the space-separated words as
separate command-line arguments to the sub-make. This could result in the
sub-make setting CC=ccache and attempting to build a target named 'gcc'.

Could we quote the variable like CC="$(HOSTCC)" to prevent this?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260617-bootconfig_using_tools-v5-0-fd589a9cc5e3@debian.org?part=3